Bug 394517

Summary:	the search-function has no results except if I search for big towns (Cannot parse osm nominatim result)
Product:	[Applications] marble	Reporter:	Hartmut <spielmops>
Component:	general	Assignee:	marble-bugs
Status:	RESOLVED FIXED
Severity:	major	CC:	kevin.kofler, metkometko, rahn
Priority:	NOR
Version:	2.1 (KDE Applications 16.12)
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Hartmut 2018-05-21 13:32:44 UTC

I used to find things with the search-function and "search area" of Marble within the Openstreetmap (not the vector-map). E.g. "camping" or "museum" or names. It worked until some weeks ago. Now not anymore. Even if I see the word "camping" on the map, Marble finds nothing. Until then Marble found things without problems even if the area was 50km wide.

Spielmops

Comment 1 Kevin Kofler 2018-05-23 02:08:26 UTC

See bug #394587 for the technical explanation.

Comment 2 Kevin Kofler 2018-05-23 02:08:51 UTC

*** Bug 394587 has been marked as a duplicate of this bug. ***

Comment 3 Kevin Kofler 2018-05-23 02:09:18 UTC

Actually, let's repost it here:

Nominatim searches in Marble 2.2.20 (KDE Applications 17.12.1) recently stopped working. On the console, the warning:
Cannot parse osm nominatim result
is printed. No results appear.

I suspect that this is because http://nominatim.openstreetmap.org/ now redirects to https://nominatim.openstreetmap.org/ , so the URL fragment at OsmNominatimSearchRunner.cpp:53 needs to be updated. And you probably also want to fix your code to support redirects.

Comment 4 Kevin Kofler 2018-05-30 09:19:06 UTC

Ping? This is a regression that completely breaks an essential feature of Marble, and it looks like the fix may be trivial (one character), can somebody please look into it?

I am setting this to CONFIRMED because we are already at least 2 people seeing it and there is clearly a reproducible bug here.

Comment 5 Metko 2018-05-31 10:16:32 UTC

Count me in! Nominatim search doesn't work for me either. Tested different (older) versions of marble and different users on my computer, and invariably got the same result: apart from city names, nothing is found in searches (e.g. the example in the manual Baker Street, London). This behavior supports Kevin's explanation.

Comment 6 Kevin Kofler 2018-06-12 11:18:47 UTC

Ping?

Comment 7 Hartmut 2018-07-06 16:54:32 UTC

Very unusual, that nobody works on this one character ...

Comment 8 Torsten Rahn 2018-09-12 15:08:44 UTC

I can confirm this as well. Unfortunately changing the url to https inside

src/plugins/runner/nominatim-search/OsmNominatimSearchRunner.cpp

doesn't change the behavior either - odd. Did they make changes to the user agent testing as well?

Comment 9 Kevin Kofler 2018-09-13 02:07:13 UTC

> Did they make changes to the user agent testing as well?

I don't know. You'd have to ask the OSM admins directly.

Comment 10 Torsten Rahn 2018-09-21 08:36:18 UTC

Sorry guys, I've just fixed the issue in master and backported the fix to the last few releases. It was indeed just about changing http to https. Can you confirm that it works again as expected? :-)

Comment 11 Kevin Kofler 2019-01-05 16:51:17 UTC

I can confirm that this is fixed at least in 18.12.0 (I think, in some 18.08.x too, but I went directly from 18.04.3 to 18.12.0). I tested with marble-18.12.0-1.fc28 on Fedora 28. Thanks!