Summary: | Translation count columns should be right-aligned | ||
---|---|---|---|
Product: | [Applications] lokalize | Reporter: | Karl Ove Hufthammer <karl> |
Component: | project management | Assignee: | Karl Ove Hufthammer <karl> |
Status: | RESOLVED FIXED | ||
Severity: | minor | ||
Priority: | NOR | ||
Version: | 2.0 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/lokalize/c97fa50b0b31c905cfb7a2bfacb679e747c92547 | Version Fixed In: | 18.04.2 |
Sentry Crash Report: |
Description
Karl Ove Hufthammer
2018-05-21 09:50:13 UTC
Proposed patch available at https://phabricator.kde.org/D13098 Git commit c97fa50b0b31c905cfb7a2bfacb679e747c92547 by Karl Ove Hufthammer. Committed on 28/05/2018 at 20:16. Pushed by huftis into branch 'Applications/18.04'. Right-align all translation count columns in Project Overview Summary: Before this patch, all columns in the Project Overview tab were left-aligned. The patch changes the alignment for the four translation count columns (‘Total’, ‘Translated’, ‘Not ready’ and ‘Untranslated’) to right alignment. The effect is that the counts are easier to compare across files, since the unit, ‘tens’, ‘hundreds’ etc. parts of the numbers are now aligned. FIXED-IN: 18.04.2 Test Plan: # Open a localisation project # Observe that four translation count columns (‘Total’, ‘Translated’, ‘Not ready’ and ‘Untranslated’) are now right-aligned, while they used to be left-aligned. # Observe that no other columns change alignment. Reviewers: ltoscano, shaforostoff, sharvey, ngraham, aacid, #localization Reviewed By: aacid, #localization Subscribers: oysteins, kde-i18n-doc Tags: #localization Differential Revision: https://phabricator.kde.org/D13098 M +31 -14 src/project/projectmodel.cpp https://commits.kde.org/lokalize/c97fa50b0b31c905cfb7a2bfacb679e747c92547 |