Bug 394295

Summary: TabBar tabs don't connect with the line below them
Product: [Frameworks and Libraries] frameworks-qqc2-desktop-style Reporter: Nate Graham <nate>
Component: generalAssignee: Marco Martin <notmart>
Status: RESOLVED FIXED    
Severity: normal CC: kde, kde, matheus4551
Priority: NOR    
Version: 5.46.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=394296
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Kirigami tab widget in Gallery - inactive tabs don't connect
New screenshot

Description Nate Graham 2018-05-15 21:39:39 UTC
Created attachment 112676 [details]
Kirigami tab widget in Gallery - inactive tabs don't connect

in Kirigami gallery, the inactive tabs don't connect with the line underneath them. This is either a bug, or a design choice that *looks* like a bug. :) See attached screenshot.
Comment 1 Kai Uwe Broulik 2018-05-16 08:45:32 UTC
Bug in qqc2-desktop-style:

//Some QStyles seem to not return sensible pixelmetrics here
    implicitHeight: Math.max(Kirigami.Units.gridUnit * 2, contentItem.implicitHeight)

That causes the TabBar's height to be too large so the tab buttons don't align with/overlap the bottom line of the TabBar. Removing that line fixes it for Breeze but the comment is probably there for a reason.
Comment 2 David Edmundson 2019-01-26 23:26:14 UTC
Created attachment 117667 [details]
New screenshot

Is it still an issue?
Comment 3 Nate Graham 2019-01-27 16:36:37 UTC
Hmm, can no longer reproduce in any context. Looks like this is fixed!