| Summary: | Redundant title in grouping plasmoid + folder view | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Alex L <alexlong92> |
| Component: | Folder | Assignee: | Eike Hein <hein> |
| Status: | CONFIRMED --- | ||
| Severity: | minor | CC: | jr, nate, plasma-bugs |
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-desktop/28dc6b88538ebb9606db8678c40a2040d9d870f9 | Version Fixed In: | |
| Attachments: |
redundant "home" title
In Plasma 5.13 |
||
You can hide the Folder View label in its settings. (In reply to Eike Hein from comment #1) > You can hide the Folder View label in its settings. Of course, but then the label in tab bar disappear too, replaced by a generic "folder view". Right. Good point. Patch under review: https://phabricator.kde.org/D12775 Incredibly fast, thanks! Git commit 28dc6b88538ebb9606db8678c40a2040d9d870f9 by Eike Hein. Committed on 11/05/2018 at 08:51. Pushed by hein into branch 'Plasma/5.12'. Always set applet title, even when label is disabled Summary: Except when we're a containment. This way Folder View applets always have a nice tab title in the grouping applet. Reviewers: #plasma Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D12775 M +15 -15 containments/desktop/package/contents/ui/FolderViewLayer.qml https://commits.kde.org/plasma-desktop/28dc6b88538ebb9606db8678c40a2040d9d870f9 Created attachment 113462 [details]
In Plasma 5.13
I'm reopening because:
> Of course, but then the label in tab bar disappear too, replaced by a generic "folder view".
while now instead of "folder view" there is a path (so it's even worse). See the attachment "Plasma 5.13".
-----
Anyway I think that the expected behavior is not avoiding redundant title by disabling it in Folder View settings, but the label in grouping plasmoid should display:
* "Folder View" if Folder View has disabled the title
* else default/custom/path label
Folder View plasmoid shouldn't display any title when placed in a grouping plasmoid.
OK, I'll try to revamp the settings a bit for 5.14. It's a bit sad though - it'll make it look a lot more complex. Right now it's a single combo box, then it needs to be a combobox and an awkward "Show Label" checkbox. All for the grouping plasmoid ... |
Created attachment 112504 [details] redundant "home" title As the title says, look at the attached image