Summary: | breeze-icons >=5.46.0 fails its scalable test | ||
---|---|---|---|
Product: | [Plasma] Breeze | Reporter: | Heiko Becker <heiko.becker> |
Component: | Icons | Assignee: | andreas <kainz.a> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | andreas_k, kainz.a, KaiUweBroulik2, kensington, nate |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/breeze-icons/e7330e352bb17e7320c0b16f9aa32fe70384788e | Version Fixed In: | 5.49 |
Description
Heiko Becker
2018-05-08 13:03:41 UTC
Andreas, any idea how to resolve this issue? Additionally, are systray icons part of the icon theme or the workspace theme? kai want's the system tray icon in breeze-icons and it look that there is no larger app icon needed, so I'm not interested in draw one when it's not needed. So if I understand the issue correctly, we would need to make a whitelist for icons that do not need to be scalable to arbitrary sizes, and exclude them from the tests that check scalability? Git commit e7330e352bb17e7320c0b16f9aa32fe70384788e by David Faure, on behalf of Maximiliano Curia. Committed on 08/08/2018 at 09:44. Pushed by dfaure into branch 'master'. ScalableTest, add "scalable" plasma-browser-integration With the introduction of the plasma-browser-integration icon (Add plasma-browser-integration system tray icon, 47b8e71a) the ScalableTest started failing [1]. The test seems to expect a "larger" icon (greater than 48) available to consider that there is a scalable icon. I'm not sure if this test is still useful, as all the icons are now in svg format, and while they might be designed for a low resolution, they are "scalable". This patch simply adds symlinks to the 48 and 64 res, in order to make the test pass. [1]: https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/81/ FIXED-IN: 5.49 A +1 -0 icons-dark/apps/48/plasma-browser-integration.svg A +1 -0 icons-dark/apps/64/plasma-browser-integration.svg A +1 -0 icons/apps/48/plasma-browser-integration.svg A +1 -0 icons/apps/64/plasma-browser-integration.svg https://commits.kde.org/breeze-icons/e7330e352bb17e7320c0b16f9aa32fe70384788e |