| Summary: | Horizontal spacing is inconsistent for different icon sizes | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Eugene G. <ezmod00> |
| Component: | view-engine: icons mode | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | justin.zobel, mail |
| Priority: | NOR | Keywords: | usability |
| Version: | 18.04.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: |
calculate item width relative to icon size
large_32px large_64px medium_32 medium_64 patch v2 |
||
Created attachment 112399 [details]
large_32px
Created attachment 112400 [details]
large_64px
Created attachment 112401 [details]
medium_32
Created attachment 112402 [details]
medium_64
Looks great! Consider submitting this patch to phabricator.kde.org, where other developers can review the patch and give you feedback for it. Thanks for not only reporting this bug but also providing a patch for it, that is truly amazing :) So i've tested it for a few days, doesn't seem to look weird. Here is a review request: https://phabricator.kde.org/D12983 Created attachment 112753 [details]
patch v2
Requested on phab to see if we can move the patch to Gitlab and continue the work on it. |
Created attachment 112398 [details] calculate item width relative to icon size Currently dolphin's icon view calculates item width in fixed increments (48px + [0 | 64 | 128]) This causes some weird things. For example: 1. Set icon size to 112px. 2. Set width to "small". 3. Set width to "medium". Nothing visually changes. 4. Set width to "large". Now there are suddenly a big spaces between the icons. The proposed patch instead calculates the item's width from the current icon size. It may need some tweaks to feel right; please test