| Summary: | m4a audio files are not considered | ||
|---|---|---|---|
| Product: | [Applications] Elisa | Reporter: | avlas <jsardid> |
| Component: | general | Assignee: | Matthieu Gallien <matthieu_gallien> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | a.stippich, nate |
| Priority: | NOR | ||
| Version: | 0.1 | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
|
Description
avlas
2018-04-13 22:40:38 UTC
Thanks for your report. I am pretty sure that you have m4a files that are not discovered but in my case they are discovered. I would like to understand what happens in order to find a solution for you. Are you depending on Baloo to find your music or the music indexer embedded in Elisa ? Baloo is active in my system and the music folder is not filtered out in Baloo. I tried to set the music folder manually as my music didn't appear, but that didn't make the songs to appear either Do the files have their album name tagged in the metadata? There is currently a bug that prevents adding files whose album tag is missing, which I'm working towards fixing. They were set to "Varis" (i.e. Several) by default. [I tried to import proper metadata using Kid3 but it automatically converts the characters introduced to Chinese on saving (!?!), but that's another story...] As long as something is written in the album tag it should work, then it is probably a different bug. Could you try the sample file from https://phabricator.kde.org/source/kfilemetadata/browse/master/autotests/samplefiles/ in the same location and see if it works? It doesn't work either. Perhaps there is some missing dependency not marked as such in KDE neon package and that's why m4a files are neglected... ? However, m4a files work just fine in Dragon Player... In Elisa all I can see is a couple of mp3 files I have in my system outside the Music folder (found by baloo). I got it working, finally. It seems the problem was indeed the metadata, which was mostly empty. Once I imported the titles from the filenames into the metadata, Elisa catched the audio files. I think, however, that Elisa should be able to rely not only on metadata but also on filenames, shouldn't it? I was assuming that any audio file would appear in Elisa (regardless of the metadata, i.e. even though it may be empty)... Ideally using "uncategorized" tags or alike, but still present (with a plus if the tags could be edited and/or imported from music databases). So, we should do exactly that. When there is no title, we could use the filename without extension. That would have maybe fixed your problem. (In reply to Matthieu Gallien from comment #8) > So, we should do exactly that. When there is no title, we could use the > filename without extension. That would have maybe fixed your problem. Yes, that would be good. Thank you Git commit baaa5386311384dc9dc3b6d221493a9b244fb0ca by Alexander Stippich. Committed on 12/10/2018 at 18:55. Pushed by astippich into branch 'master'. allow metadata of tracks without album and tracknumber in database Summary: remove not null constrain for database and change sql query to allow tracks with more incomplete metadata Related: bug 389136, bug 396607 Test Plan: tests pass as before, new tests pass as well Reviewers: mgallien Reviewed By: mgallien Tags: #elisa Differential Revision: https://phabricator.kde.org/D13685 M +192 -2 autotests/databaseinterfacetest.cpp M +43 -39 src/databaseinterface.cpp https://commits.kde.org/elisa/baaa5386311384dc9dc3b6d221493a9b244fb0ca Git commit 4ace01ef214d1c99b55fdc64392efb7d05faada2 by Alexander Stippich. Committed on 17/11/2018 at 09:11. Pushed by astippich into branch 'master'. add a test for tracks with empty artist tag in database Summary: adds a test for tracks with empty artist tag in database, currently failing Related: bug 389136, bug 396607 Reviewers: mgallien Reviewed By: mgallien Tags: #elisa Differential Revision: https://phabricator.kde.org/D16193 M +95 -0 autotests/databaseinterfacetest.cpp https://commits.kde.org/elisa/4ace01ef214d1c99b55fdc64392efb7d05faada2 Can you try the latest version of Elisa and see if those commits fixed the problem for you? Thanks! Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! |