Summary: | Crop Tool: crop image without cropping the layers data | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | reptillia39 |
Component: | General | Assignee: | ddoran3 |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | artgoat, ddoran3, dimula73, raghu, storm.anthro, tamtamy.tymona |
Priority: | NOR | ||
Version: | 4.0.1 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | All | ||
Latest Commit: | https://invent.kde.org/graphics/krita/commit/b80b01542a189b5ccbb606bfa0e22c74c733f3ec | Version Fixed In: |
Description
reptillia39
2018-04-13 19:18:03 UTC
Also, I tried putting the status to 'wishlist'. Not working. Where do I report that issue? Upgrading the bug to a wishlist WISHGROUP: Small Usability Fixes *** Bug 388254 has been marked as a duplicate of this bug. *** This is a feature that has a lot of valid use cases, so I second it. This has valid uses, but I also depend on the crop tool to get rid of "extra stuff" outside the visible image boundary, so that I'm not saving a lot of image layer information that I'll never use. Perhaps "image resize" is a better way of accomplishing this? (although the current image resize tool is less than amazing). Victor, I don't understand why you want this functionality placed in a different tool when it can simply be a checkbox on the tool settings of the corp tool? The dialog to change canvas size is nice and all when you do something calculated but doesn't allow simple visual re-composing of the canvas in the way the crop tool would if the checkbox to not discard off-canvas areas is added. Hi Victor, To get rid of the content beyond the canvas boundary there is always Image > Trim to Image Size menu. you can also add a keyboard shortcut for that, it seems better for your use case. (In reply to Raghavendra kamath from comment #7) > Hi Victor, > > To get rid of the content beyond the canvas boundary there is always Image > > Trim to Image Size Thanks! That is very likely exactly what I'm looking for. A lot of times in Krita, the functionality has already been anticipated, but finding it is not always the easiest. So I was looking into adding this: Replacing the current functionality is a one line change, but we may want to keep the old image crop. Perhaps the new one should be added as a new CropType (called Canvas?) (CropType is the drop down menu "Applies to:"). At the moment the CropType drop down is disabled when a raster layer isn't selected, as layer cropping doesn't make sense in that case. Image and the new mode should be selectable at any time, so adding a new CropType would require re-working this. Adding a simple checkbox is also an option but that checkbox should be disabled when doing a layer crop, so it's not necessarily a lazy solution. I'd like to hear opinions on how I should proceed. @ddoran3: Hi, please do add a checkbox in Tool Options. There is no need for a new tool and replacing the behaviour would be undesireable. Disabling the checkbox when one is using "Layer" or "Frame" (which exists on master) crop is a good idea. It's better to have it the least confusing to the end user than having it pretty in terms of the minimal code needed. Thanks for working on that :) (I'm assigning you to the report, please in case you decide that you won't be working on it any more and you can't submit the fix, write a comment here so the bug report will be set to Confirmed again and someone else can start working on it). A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/800 Git commit b80b01542a189b5ccbb606bfa0e22c74c733f3ec by Daniel Doran. Committed on 13/04/2021 at 22:43. Pushed by dkazakov into branch 'master'. Add "Canvas" crop mode. Canvas will change the size of the canvas without cropping any layers. M +9 -3 plugins/tools/tool_crop/kis_tool_crop.cc M +1 -0 plugins/tools/tool_crop/kis_tool_crop.h M +13 -3 plugins/tools/tool_crop/kistoolcropconfigwidget.cpp M +5 -0 plugins/tools/tool_crop/wdg_tool_crop.ui https://invent.kde.org/graphics/krita/commit/b80b01542a189b5ccbb606bfa0e22c74c733f3ec |