| Summary: | Krita 4.0.1 fails to build on armv7l | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Wolfgang Bauer <wbauer1> |
| Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | halla |
| Priority: | NOR | ||
| Version: | 4.0.1 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/krita/39e28e703aa8144c403c1ee53afc47c0121908c1 | Version Fixed In: | |
| Sentry Crash Report: | |||
Did you try that change? If so, we can simply push it. (In reply to Boudewijn Rempt from comment #1) > Did you try that change? If so, we can simply push it. I don't understand, that change is already in 4.0.1, it causes the failure AFAICT. Or do you mean I should try to move the line below the endif()? Haven't done that yet, but will. Yes, I mean that you should try the change moving the line. I cannot test with arm. Confirmed.
This patch gets rid of the error:
diff --git a/CMakeLists.txt b/CMakeLists.txt
index bef818bc0f..f8658a11d1 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -630,8 +630,8 @@ if (NOT ${CMAKE_SYSTEM_PROCESSOR} MATCHES "arm")
PURPOSE "Required by the Krita for vectorization")
macro_bool_to_01(Vc_FOUND HAVE_VC)
endif()
- configure_file(config-vc.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-vc.h )
endif()
+configure_file(config-vc.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-vc.h )
if(HAVE_VC)
message(STATUS "Vc found!")
The build still fails, but that's a different story, something related to OpenGL... (that happened before)
Git commit d3eb595b444d5b198189404448e93121d7796d17 by Boudewijn Rempt. Committed on 11/04/2018 at 17:26. Pushed by rempt into branch 'master'. Fix build on ARM (partly) (cherry picked from commit 39e28e703aa8144c403c1ee53afc47c0121908c1) M +1 -1 CMakeLists.txt https://commits.kde.org/krita/d3eb595b444d5b198189404448e93121d7796d17 Thanks. I've pushed that change. Thanks. FYI: The other build failure I mentioned (related to OpenGL) may be related to how Qt is built on openSUSE AFAIK. Our ARM guys are aware of the issue though, I'll let them handle it. I just noticed this new problem when I updated krita today, and thought it was a good idea to get it fixed. ;-) And IMHO, it just seems logical to have config-vc.h created in any case, as that defines HAVE_VC for the rest of the source. Yes, definitely. Git commit b832b5f508c6f2378e47732f7615bd13fa41a48d by Boudewijn Rempt. Committed on 02/05/2018 at 11:54. Pushed by rempt into branch 'krita/4.0'. Fix build on ARM (partly) (cherry picked from commit 39e28e703aa8144c403c1ee53afc47c0121908c1) (cherry picked from commit 55e1d8deaf98721ed3fdaf72e4a6f942ea5b93a7) M +1 -1 CMakeLists.txt https://commits.kde.org/krita/b832b5f508c6f2378e47732f7615bd13fa41a48d Git commit 39e28e703aa8144c403c1ee53afc47c0121908c1 by Boudewijn Rempt. Committed on 11/04/2018 at 17:25. Pushed by rempt into branch 'rempt/update-frameworks'. Fix build on ARM (partly) M +1 -1 CMakeLists.txt https://commits.kde.org/krita/39e28e703aa8144c403c1ee53afc47c0121908c1 |
In file included from /home/abuild/rpmbuild/BUILD/krita-4.0.1/libs/pigment/compositeops/KoOptimizedCompositeOpFactoryPerArch.h:24:0, from /home/abuild/rpmbuild/BUILD/krita-4.0.1/libs/pigment/compositeops/KoOptimizedCompositeOpFactory.cpp:20: /home/abuild/rpmbuild/BUILD/krita-4.0.1/libs/pigment/compositeops/KoVcMultiArchBuildSupport.h:23:10: fatal error: config-vc.h: No such file or directory #include "config-vc.h" ^~~~~~~~~~~~~ compilation terminated. This didn't happen with 4.0.0. IMO, this change causes it: https://cgit.kde.org/krita.git/commit/?id=bc400ff2bd6d0effea75b976a61a6f09634750cd The config-vc.h file creation should probably stay outside the if()/endif()...