Summary: | Tab loading spinner not always replaced with website's icon | ||
---|---|---|---|
Product: | [Applications] Falkon | Reporter: | Richard Ullger <rullger> |
Component: | general | Assignee: | David Rosca <nowrep> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | private2.6.3 |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
URL: | https://smarkets.com/ | ||
Latest Commit: | https://commits.kde.org/falkon/17d45d718cb2e3912c9494491232ab9cdf9b5a9c | Version Fixed In: | 3.0.1 |
Attachments: | Tab spinner with tab context menu |
Description
Richard Ullger
2018-04-08 17:28:30 UTC
Can't reproduce (load spinner disappears), but I can reproduce issue related to this - in right click it always show "Stop" action which should only be visible when page is loading. Created attachment 111919 [details]
Tab spinner with tab context menu
The context menu shows the option to reload the tab while the load spinner is still visible.
Sorry for not being clear, but I meant right click context menu in website, not on the tabbar. I only get the 'Stop' option in the page context menu where the tab contains a load spinner. If the tab has been refreshed with the website's icon, I see the 'reload' option in the page context menu. In the tabbar context menu I see a 'Stop' option while the page is actually still loading. When the page has loaded I see a 'Reload' option even if the tab is still showing the load spinner. I get a similar result at https://www.betfair.com but in this case the tab load spinner is never replaced with the website's icon. @Richard Ullger The "load spinner" problem is a Qt bug: https://bugreports.qt.io/browse/QTBUG-65223. There is a workaround in Falkon source, but it's currently adjusted only for Qt 5.10.* > The "load spinner" problem is a Qt bug: https://bugreports.qt.io/browse/QTBUG-65223.
Yes, but I was under impression that it was fixed in 5.11. At least with Qt 5.11 beta it looked fine.
Can you please confirm that applying that workaround also for Qt 5.11 fixes the issue?
>Can you please confirm that applying that workaround also for Qt 5.11 fixes the issue? Sorry, but currently i dont have compiled Qt 5.11 to try with. I just thought you are with 5.10 as well as i noticed the bug is not marked as fixed yet, so that why a was sure there is the problem... @Richard Ullger, i hope you can help here! You may use this patch: https://src.fedoraproject.org/cgit/rpms/falkon.git/plain/falkon-3.0.0-qtbug-65223-workaround.patch @private2.6.3 Falkon built against qt5 5.11.0beta3 which is now the version in the kde_unstable Arch repo with your patch applied fixes the issue. Many thanks. Git commit 17d45d718cb2e3912c9494491232ab9cdf9b5a9c by David Rosca. Committed on 11/04/2018 at 16:32. Pushed by drosca into branch 'Falkon/3.0'. WebPage: Use load finished workaround unconditionally It seems to be broken, again, with QtWebEngine 5.11. FIXED-IN: 3.0.1 M +6 -8 src/lib/webengine/webpage.cpp https://commits.kde.org/falkon/17d45d718cb2e3912c9494491232ab9cdf9b5a9c |