Summary: | "Open File" dialog: "Open File Manager" (file context menu) should select the file in Dolphin | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Gregor Mi <codestruct> |
Component: | general | Assignee: | David Faure <faure> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | kdelibs-bugs, nate |
Priority: | NOR | ||
Version: | 5.44.0 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kio/05fe10da0034127b25c1e828c348af4035451d84 | Version Fixed In: | |
Attachments: | "Open File Manager" context menu item |
Description
Gregor Mi
2018-03-25 19:19:56 UTC
Created attachment 111643 [details]
"Open File Manager" context menu item
Looks like this is using custom code instead of KIO::highlightInFileManager(). That'll fix the issue as well as make the string use common terminology. Here, have patch! https://phabricator.kde.org/D11705 Git commit 05fe10da0034127b25c1e828c348af4035451d84 by Nathaniel Graham. Committed on 26/03/2018 at 22:26. Pushed by ngraham into branch 'master'. Highlight selected items when showing parent folder from the open/save dialog Summary: For the open/save dialogs' {nav Open File Manager} context menu item, this patch adopts `KIO::highlightInFileManager()` and modernizes the name to match current convention ("Open Containing Folder"). Test Plan: Deploy change and invoke the open dialog from Kate, then... - Right-click on one or more items and select {nav Open Containing Folder}. See that items are highlighted in the window that opens. - Right-click on the background (i.e. select nothing) and select {nav Open Containing Folder}. See that current folder is highlighted in the window that opens. Reviewers: #frameworks, broulik Reviewed By: broulik Subscribers: broulik Tags: #frameworks Differential Revision: https://phabricator.kde.org/D11705 M +8 -2 src/filewidgets/kdiroperator.cpp https://commits.kde.org/kio/05fe10da0034127b25c1e828c348af4035451d84 |