| Summary: | Krunner needs two up/down key presses to move list selection | ||
|---|---|---|---|
| Product: | [Plasma] krunner | Reporter: | Nikolaos Kakouros <tterranigma> |
| Component: | general | Assignee: | Kai Uwe Broulik <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns, kde, nate |
| Priority: | NOR | Keywords: | usability |
| Version First Reported In: | 5.12.3 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-workspace/b8ffa755ed2df6bf6a47b9268e7da93355a4d856 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Nikolaos Kakouros
2018-03-22 21:13:47 UTC
The first entry is fake selected even though focus is on the text field. Pressing down focusses the view, and only after that do up/down move the current index.
> I cannot imagine a use case that it satisfies
keyboard selections of actions on the first result.
Not to say this isn't an issue, but doing the "obvious" fix would probably break it
Here's a patch: https://phabricator.kde.org/D11611 This patch doesn't break keyboard selection of the "Open containing folder" action for the first result, it only changes it a bit (details in the patch). Git commit b8ffa755ed2df6bf6a47b9268e7da93355a4d856 by Nathaniel Graham.
Committed on 23/03/2018 at 14:19.
Pushed by ngraham into branch 'Plasma/5.12'.
Move to KRunner's second results item with a single keypress
Summary:
Currently, to navigate the list of results after typing a search term, you need to press the down arrow twice: first to focus the result list, and a second time to actually change the selection. This patch fixes that by changing the selection during the focus oprtation.
Test Plan:
Deployed change, killed, restarted, and activated KRunner, typed a search term:
- The down arrow key now moves to the second item
- Clicked on the text field; up arrow now moves to the previous item in the results list
Activating the {nav Open Containing Folder} button for the first result via the keyboard changes slightly with this patch:
- Currently, it's {nav down arrow > tab key}
- With this patch, it's {nav tab key three times} or {nav down arrow > shift + tab}
Seems like an acceptable change to me to better support the common case of just wanting to easily navigate to the results list items.
Reviewers: #plasma, broulik, mart
Reviewed By: #plasma, broulik, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11611
M +4 -2 lookandfeel/contents/runcommand/RunCommand.qml
https://commits.kde.org/plasma-workspace/b8ffa755ed2df6bf6a47b9268e7da93355a4d856
|