Summary: | No prompt when switching with unsaved changes | ||
---|---|---|---|
Product: | [Applications] systemsettings | Reporter: | David Edmundson <kde> |
Component: | sidebarview | Assignee: | Marco Martin <notmart> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | rizzitello |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/systemsettings/0aa7fd015b0cef0f8982d271809aa6186e5a8877 | Version Fixed In: | |
Sentry Crash Report: |
Description
David Edmundson
2018-03-22 01:22:44 UTC
*** Bug 391162 has been marked as a duplicate of this bug. *** Fixed by: https://phabricator.kde.org/D12686 Git commit 0aa7fd015b0cef0f8982d271809aa6186e5a8877 by David Edmundson. Committed on 14/05/2018 at 13:39. Pushed by davidedmundson into branch 'master'. Fix sidebar view regression of not prompting about unsaved changes Summary: When you switch module with unsaved changes the other modes prompt if you want to save the changes. Sidebar mode did not. Test Plan: Made a change, clicked another module. Got a prompt. Clicked apply, it applied then changed Tried again Clicked cancel, it didn't change Reviewers: #plasma, broulik Reviewed By: #plasma, broulik Subscribers: broulik, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D12686 M +8 -2 sidebar/SidebarMode.cpp M +1 -2 sidebar/package/contents/ui/CategoriesPage.qml M +1 -5 sidebar/package/contents/ui/SubCategoryPage.qml https://commits.kde.org/systemsettings/0aa7fd015b0cef0f8982d271809aa6186e5a8877 |