| Summary: | static (???) drop shadow image is super pixely | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-knewstuff | Reporter: | Harald Sitter <sitter> |
| Component: | general | Assignee: | Dan Leinir Turthra Jensen <admin> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | admin, kdelibs-bugs, nate |
| Priority: | NOR | ||
| Version: | 5.43.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/knewstuff/e1f5782a85186cc61c5ad55faa33ad5fdae729a9 | Version Fixed In: | 5.58 |
| Sentry Crash Report: | |||
| Attachments: | screenshot of the problem | ||
Confirmed, this looks awful. Hmm... It does look really terrible in general... An easy fix is super easy, of course, and really just needs doing (i'll have a patch up momentarily), but do we /want/ a less terrible looking shadow here? It'll take a touch of effort to get that to happen, and it'd be a shame to do so if we don't really want to have it anyway ;) Git commit e1f5782a85186cc61c5ad55faa33ad5fdae729a9 by Dan Leinir Turthra Jensen. Committed on 25/04/2019 at 10:07. Pushed by leinir into branch 'master'. Remove pixelated border Summary: In the before-times, drop shadows were considered vitally important on everything, and so it was introduced to KNewStuff's dialogues as well. It was, however, never done quite right, and it's making our dialogues look all silly. So, we remove it for now, and if we still want it, we can reintroduce them in a more modern fashion. Test Plan: Open the details dialogue of any knewstuff listing Before patch: See pixelated (and weirdly positioned) pixelated border on all preview images After patch: See no pixelated border Reviewers: #knewstuff, ngraham, sitter, #vdg Reviewed By: ngraham, #vdg Subscribers: anthonyfieroni, mmustac, ndavis, kde-frameworks-devel, #knewstuff Tags: #frameworks, #knewstuff Differential Revision: https://phabricator.kde.org/D20693 M +0 -4 data/CMakeLists.txt D +- -- data/thumb_frame.png M +0 -4 src/ui/imagepreviewwidget.cpp M +0 -1 src/ui/imagepreviewwidget_p.h https://commits.kde.org/knewstuff/e1f5782a85186cc61c5ad55faa33ad5fdae729a9 |
Created attachment 111020 [details] screenshot of the problem See screenshot. Previews in the download dialog have a forced drop shadow added. It's super low quality though and looks like borrowed from minecraft.