| Summary: | knewstuff renders all screenshots as squares | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-knewstuff | Reporter: | Harald Sitter <sitter> |
| Component: | general | Assignee: | Jeremy Whiting <jpwhiting> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | admin, kdelibs-bugs, nate, notuxius |
| Priority: | NOR | ||
| Version: | 5.43.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=391792 | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: |
screenshot of a konsole theme squared up
actual konsole theme screenshot (from store) wallpaper preview also squared up some wallpapers are squared server-side Thumbnails still squares |
||
|
Description
Harald Sitter
2018-02-26 16:00:19 UTC
Created attachment 111015 [details] screenshot of a konsole theme squared up https://store.kde.org/p/1216368 https://cn.pling.com/img/2/2/6/b/434f0eeedc80bfb1fe0e0a87d1dcbd77cc6d.png Created attachment 111016 [details]
actual konsole theme screenshot (from store)
Created attachment 111017 [details] wallpaper preview also squared up https://store.kde.org/p/1216721 https://cn.pling.com/img/1/7/9/0/ee60e858c8fdad44377a3a379cab8d3d49a3.jpg Created attachment 111018 [details] some wallpapers are squared server-side This is possibly the strangest thing to me. This image still has the square frame but I think is actually squared server-side (that's why it has two previews). The second preview is also squared by squeezing it into the frame. https://store.kde.org/p/1217067 My current theory is that the store (randomly?) generates previews that are squared and the client always assumes it gets square input. That too seems strange though. Why would you there be strain on the server to generate the squares and then send useless bytes to the client? And I mean, if that is the case it's still nonesense because that last wallpaper I posted has 2 previews and one is wrong regardless since it hasn't a square aspect ratio. It turns out this was a serverside issue (see the linked report, which has now been closed). Ronald fixed this by changing the default crop so the data now matches the request. Thanks for trawling through it and supplying screenshots and whatnot! Created attachment 111439 [details]
Thumbnails still squares
OK, we're close! I can confirm that as of today, the actual full-size screenshots in Discover have their correct aspect ratios. But the thumbnails are still small and square (see attached screenshot). Is this on KNS, or Discover?
Got a report in Bug 401782 that this isn't fixed; re-opening. *** Bug 401782 has been marked as a duplicate of this bug. *** It turns out the change was only ever applied to the full size previews, not the thumbnails. They are now also returned with the correct aspect ratio, and as soon as caches run out and refresh and whatnot, things should start to look right :) Please do the testy thing and give word if things appear to be sorted, and then we can close the bug (again) - leaving it open until it's confirmed it works for people other than me as this is all about remote resources :) Good news: I can now see KNS entries in Discover with rectangular thumbnails! Looks like the change worked now. |
