| Summary: | Change trash-empty icon to user-trash when Breeze has new icon | ||
|---|---|---|---|
| Product: | [Applications] gwenview | Reporter: | Andrew Crouthamel <andrew.crouthamel> |
| Component: | general | Assignee: | Gwenview Bugs <gwenview-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | nate |
| Priority: | NOR | ||
| Version First Reported In: | 17.12.2 | ||
| Target Milestone: | --- | ||
| Platform: | Kubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/gwenview/118dcb14fba4d7bbd6caf3ee7c04bd052aa763d4 | Version Fixed/Implemented In: | 19.04.0 |
| Sentry Crash Report: | |||
Git commit 118dcb14fba4d7bbd6caf3ee7c04bd052aa763d4 by Shubham Jangra.
Committed on 20/01/2019 at 17:46.
Pushed by shubham into branch 'master'.
Use user-trash icon for Trash action
Summary:
FIXED-IN: 19.04.0
Test Plan:
Before:
{F6557553}
After (WITHOUT QT_SCALE_FACTOR=2 gwenview)
{F6557554}
(WITH QT_SCALE_FACTOR=2 gwenview)
{F6557555}
Reviewers: ngraham
Reviewed By: ngraham
Tags: #gwenview
Differential Revision: https://phabricator.kde.org/D18391
M +1 -4 app/fileopscontextmanageritem.cpp
https://commits.kde.org/gwenview/118dcb14fba4d7bbd6caf3ee7c04bd052aa763d4
|
Change the following line, per the code comment, once Breeze has an acceptable monochrome HiDPI-compatible icon. fileopscontextmanageritem.cpp:161 //TODO: Change this to only user-trash once Breeze makes some icon changes to clarify on HiDPI systems mTrashAction->setIcon(QIcon::fromTheme("trash-empty", QIcon::fromTheme(("user-trash"))));