| Summary: | Make error messages more prominent (was "Ignore content in mountpoints") | ||
|---|---|---|---|
| Product: | [Plasma] Plasma Vault | Reporter: | Michael Heidelbach <ottwolt> |
| Component: | general | Assignee: | Ivan Čukić <ivan.cukic> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ottwolt |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-vault/efafd9dd52059ddfcf45ba0ae450c3cc5be5714c | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Michael Heidelbach
2018-02-24 09:06:59 UTC
What do you mean by "ignore content in mountpoints"? You need to be a bit more verbose. (In reply to Ivan Čukić from comment #1) > What do you mean by "ignore content in mountpoints"? You need to be a bit > more verbose. ~/Vaults/MyVault MyVault is not mounted. $ touch ~/Vaults/MyVault/.directory Try to mount MyVault. It refuses to do so because ~/Vaults/MyVault is not empty. I think MyVault should mount nevertheless. Oh, that. FUSE denies mounting in a non-empty directory. And that is not something I'm willing to override. If this is allowed, the user might accidentally save a document in the mountpoint directory thinking the vault is open (since there are files in said directory). (In reply to Ivan Čukić from comment #3) That is very convincing. Please consider to make the refusal message more prominent. E.g. Above the password entry field and maybe in a different color. The way it is displayed now it is easy to confuse it with a comment to the password entry field. That is a good idea. :) Git commit efafd9dd52059ddfcf45ba0ae450c3cc5be5714c by Ivan Čukić. Committed on 10/04/2018 at 21:41. Pushed by ivan into branch 'master'. Making the error message when opening the vault more prominent M +16 -3 kded/ui/mountdialog.cpp M +3 -0 kded/ui/mountdialog.h M +19 -28 kded/ui/mountdialog.ui https://commits.kde.org/plasma-vault/efafd9dd52059ddfcf45ba0ae450c3cc5be5714c |