| Summary: | Audio volume slider is out of position | ||
|---|---|---|---|
| Product: | [Applications] gwenview | Reporter: | Patrick Silva <bugseforuns> |
| Component: | general | Assignee: | Gwenview Bugs <gwenview-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | harindudilshan95, nate, null |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | 18.04.3 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/gwenview/fec2cd8b655e06c6cbb624b32737651b5a45bc8c | Version Fixed In: | 18.08.0 |
| Attachments: | screenshot | ||
|
Description
Patrick Silva
2018-02-22 22:31:47 UTC
Created attachment 110913 [details]
screenshot
Interesting. For me it jumps to the correct position as soon as I try to move the slider. (Could be either JJ or very hard…) When you change the volume, boundingRect() of HudSlider seems to change for no reason at all. Perhaps it's related to QGraphicsWidget. Would you be interested in submitting a patch, Kavinda? Our documentation for this can be found at: - https://community.kde.org/Get_Involved/development - https://community.kde.org/Infrastructure/Phabricator I would have if I could. I don't think it's a easy job. Patch available at https://phabricator.kde.org/D14578 Git commit fec2cd8b655e06c6cbb624b32737651b5a45bc8c by Peter Mühlenpfordt.
Committed on 05/08/2018 at 07:14.
Pushed by muhlenpfordt into branch 'Applications/18.08'.
Fix video controls volume slider not vertically centered sometimes
Summary:
The volume slider of the video controls overlay is sometimes not
centered vertically. This happens mostly on KDE Neon or if Gwenview
is started to show a video by commandline argument.
This is caused by calculating the slider and handle positions before
initializing the widget and therefore using wrong values. After the
first slider change this is correctly updated.
This patch delays the initialization of the slider to give the
overlay widget time to setup.
FIXED-IN: 18.08.0
Before:
{F6173671, size=full}
After:
{F6173673, size=full}
Test Plan:
* Start Gwenview with video file as commandline argument
* Check that all sliders are vertically centered in controls overlay
* Check in current KDE Neon system
Reviewers: #gwenview, rkflx
Reviewed By: #gwenview, rkflx
Subscribers: rkflx
Differential Revision: https://phabricator.kde.org/D14578
M +4 -1 lib/hud/hudslider.cpp
https://commits.kde.org/gwenview/fec2cd8b655e06c6cbb624b32737651b5a45bc8c
|