Bug 390856

Summary:	Improve usability of filename template configuration
Product:	[Applications] Spectacle	Reporter:	null <null>
Component:	General	Assignee:	Boudhayan Gupta <me>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	bugseforuns, nate, rpgd
Priority:	NOR	Keywords:	investigated, junior-jobs, triaged
Version:	17.12.2
Target Milestone:	---
Platform:	Other
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=381175
Latest Commit:	https://commits.kde.org/spectacle/431ea89f51ae79ca0686617d29a3129f130a1fb2	Version Fixed In:	19.04.0
Sentry Crash Report:

Description null 2018-02-21 16:51:55 UTC

In Spectacle's "Configure → Save" page, you can set the template used for populating the "Save" filename field. Currently it looks like this, and you have to manually type the placeholders:

  Screenshot_%Y%M%D_%H%m%S

In Gwenview's importer (type "gwenview_importer .", click on "Settings"), a similar workflow is implemented much easier, because the placeholders are in a more readable/longer format and you can just click on them.

Port Gwenview's template input widget to Spectacle to improve the user experience.

Note: The filename preview part is handled in Bug 381175.

(Bonus task: Extract this into a reusable library.)

Comment 1 Rafa Portillo 2019-03-04 08:05:57 UTC

Reviewed by Rafa (not developer) from bugsquad as part of Bugday 2019-03-02
Confirmed behavior in:
Operating System: KDE neon Developer Edition
KDE Plasma Version: 5.15.80
KDE Frameworks Version: 5.56.0
Qt Version: 5.12.0

I do not have the access level to change severity to wishlist as per bugsquad guidelines.

Related to bug 381175 (also related to replicating Gwenview importer functionality), which already has severity of wishlist

Comment 2 Nate Graham 2019-03-14 17:33:36 UTC

Git commit 431ea89f51ae79ca0686617d29a3129f130a1fb2 by Nate Graham, on behalf of David Redondo.
Committed on 14/03/2019 at 17:33.
Pushed by ngraham into branch 'master'.

Make the filename placeholders clickable

Summary:
This allows the user to click the placeholders. First step to improve the filename template configuration. I also moved the available placeholders to the ExportManager. The SaveOptionsPage doesn't need to care about which options are present and we have to change them in only one class if we want to make changes.
Further steps I plan to do are displaying a preview, improving the Layout (we had to increase the size already) and eventually using better placeholders.
FIXED-IN: 19.04.0

Test Plan:
- Click on placeholder
- It appears in the LineEdit

Reviewers: #spectacle, ngraham

Reviewed By: #spectacle, ngraham

Subscribers: ngraham

Tags: #spectacle

Differential Revision: https://phabricator.kde.org/D19755

M  +13   -0    src/ExportManager.cpp
M  +3    -0    src/ExportManager.h
M  +13   -24   src/Gui/SettingsDialog/SaveOptionsPage.cpp

https://commits.kde.org/spectacle/431ea89f51ae79ca0686617d29a3129f130a1fb2