| Summary: | "Add to Places" is only available via context menu | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | bugseforuns, elvis.angelaccio, porton, shivangs44 |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | 17.12.2 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/dolphin/7cad80b292ef4ff89db5d6da924e75db4624d711 | Version Fixed In: | 19.12.0 |
| Sentry Crash Report: | |||
|
Description
Nate Graham
2018-02-19 21:55:42 UTC
There are more items that are only available via the context menu, e.g. "Open With...". If users are not able to open a context menu, maybe because their input devices does not support a second button, we should fix it on a higher level. Several applications use context menus extensively. It's a usability issue, not a hardware issue. You might be surprised by just how many users are never able to learn how to use context menus, even with a device like a multi-button mouse that makes it easy. And that's to say nothing about about laptop touchpads; even many advanced users don't use context menus on their laptops. As a design principle, context menus should be considered accelerators for advanced users, never the default UI or the only place to access a feature. can we also have a keyboard shortcut to add current location to places? Good idea. *** Bug 385523 has been marked as a duplicate of this bug. *** Could I give this a go? It would be my first commit and looks easy enough to attempt. In regards to Nate And Christoph's discussion, I think you both bring up good points. If we do agree on the idea of the context menu being an 'accelerator for advanced' users, perhaps we should get the 'open with' into the menu bar or its own icon in Dolphin? Go ahead! Be aware that there is already an outstanding patch for this (that doesn't quite work yet): https://phabricator.kde.org/D12605 Obviously only one will land, so it's all about which one is completed first! And yes, everything in the context menu should also be available in one of the main menus. It looks like the person who submitted that patch is actively working on try to fix the issues with it so I will leave them to it! If they abandon it for any reason I'll do it Git commit 7cad80b292ef4ff89db5d6da924e75db4624d711 by Nate Graham.
Committed on 01/09/2019 at 21:04.
Pushed by ngraham into branch 'master'.
Add "Add to Places" action to file menu
Summary:
It's recommended that actions available in context menus be available in the main menu
as well for discoverability's sake. This patch does so for the "Add to Places" action.
The action is moved over to the main window, and accessed in the context menu via the
actionCollection it lives in.
FIXED-IN: 19.08.0
Test Plan:
- Action still works
- Action still appears in context menu when relevant
- Action in the File menu only becomes enabled when only a single directory is selected or nothing is selected
{F7143876}
{F7143877}
{F7143878}
{F7143879}
Reviewers: #dolphin, elvisangelaccio
Reviewed By: #dolphin, elvisangelaccio
Subscribers: elvisangelaccio, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D22149
M +4 -32 src/dolphincontextmenu.cpp
M +51 -5 src/dolphinmainwindow.cpp
M +6 -1 src/dolphinmainwindow.h
M +3 -1 src/dolphinui.rc
https://commits.kde.org/dolphin/7cad80b292ef4ff89db5d6da924e75db4624d711
|