Summary: | Wayland - cannot change primary screen | ||
---|---|---|---|
Product: | [Plasma] KScreen | Reporter: | Kamil Piwowarski <9luty1992> |
Component: | kcm | Assignee: | Sebastian Kügler <sebas> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 5.12.1 | ||
Target Milestone: | --- | ||
Platform: | Manjaro | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kscreen/cd3b350e0225a3a1616804924420f86e39db50a1 | Version Fixed In: |
Description
Kamil Piwowarski
2018-02-17 21:14:12 UTC
The panel and primary screen have nothing to do with each other. You can move the panel using the panel controller. Note: Primary screen is not a concept in Wayland, it's not even well defined in X11-based Plasma, so we're moving away from it. It would be good to remove this select box on Wayland session :) I agree, we should hide the respective UI in this case: https://phabricator.kde.org/D10723 Git commit cd3b350e0225a3a1616804924420f86e39db50a1 by Sebastian Kügler. Committed on 23/02/2018 at 08:57. Pushed by sebas into branch 'master'. hide primary display combo when not supported Summary: Some backends, for example the kwayland backend, do not support setting the primary display. The backends already make their feature set known so we can just hide it from the UI. It's enough to hide it from the UI since setting it doesn't make any difference, the libkscreen backend will simply ignore it internally, so it's just honest to not show it. Test Plan: ran kscreen kcm on both, X11 and wayland platforms, combo and label are shown and hidden as expected Reviewers: #plasma, dvratil, davidedmundson Reviewed By: #plasma, davidedmundson Subscribers: kpiwowarski, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D10723 M +4 -2 kcm/src/widget.cpp M +2 -0 kcm/src/widget.h https://commits.kde.org/kscreen/cd3b350e0225a3a1616804924420f86e39db50a1 |