| Summary: | Sources list does not show any source details | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Andrew Crouthamel <andrew.crouthamel> |
| Component: | discover | Assignee: | Aleix Pol <aleixpol> |
| Status: | RESOLVED NOT A BUG | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | ||
| Version: | 5.12.1 | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: | Discover sources list showing missing source URL and details. | ||
|
Description
Andrew Crouthamel
2018-02-14 20:20:09 UTC
This was by design because before, the full string was unreadable and made the settings page look ugly and people hated it. Now for non-Ubuntu packages, we show the first part of the URL only, as seen in your screenshot for Flathub, and for Ubuntu packages, we try to synthesize a pretty string. But it looks like there are still some bugs to work out here. About half of those "Xenial (main) entries are actually source packages, and will be marked appropriately once Neon gets a new PackageKit version: https://github.com/hughsie/PackageKit/pull/238 But beyond those, there are still two other bugs I can see: - One of your repos is just ".". That shouldn't happen. - Even with half of the repos correctly displaying as "Xenial (main) sources", it still won't be clear why they all have the same name. They should probably have the same kind of shortened URL as the flathub entry, or else the synthesized string should be unique for each repo. Can you please open two new targeted bugs, one for each of those issues? (FWIW the full URL would be visible if my feature request for an edit button is implemented: Bug: 389768) Andrew, one thing we can look into is improving it upstream in PackageKit: https://github.com/hughsie/PackageKit/blob/master/backends/aptcc/apt-sourceslist.cpp#L448 (In reply to Nate Graham from comment #1) > This was by design because before, the full string was unreadable and made > the settings page look ugly and people hated it. Now for non-Ubuntu > packages, we show the first part of the URL only, as seen in your screenshot > for Flathub, and for Ubuntu packages, we try to synthesize a pretty string. > But it looks like there are still some bugs to work out here. > > About half of those "Xenial (main) entries are actually source packages, and > will be marked appropriately once Neon gets a new PackageKit version: > https://github.com/hughsie/PackageKit/pull/238 > > But beyond those, there are still two other bugs I can see: > - One of your repos is just ".". That shouldn't happen. > - Even with half of the repos correctly displaying as "Xenial (main) > sources", it still won't be clear why they all have the same name. They > should probably have the same kind of shortened URL as the flathub entry, or > else the synthesized string should be unique for each repo. > > Can you please open two new targeted bugs, one for each of those issues? > > (FWIW the full URL would be visible if my feature request for an edit button > is implemented: Bug: 389768) Ah ok. I will make some more bugs :). Like you said in bullet #2, my one repo I added above (deb https://download.virtualbox.org/virtualbox/debian xenial contrib) now shows in the list at the bottom, as just "Xenial (contrib)". So there's no knowing it is the virtualbox one, since they have it named "contrib" instead of "virtualbox". |