Bug 390474 - Sources list does not show any source details
Summary: Sources list does not show any source details
Status: RESOLVED NOT A BUG
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.12.1
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-14 20:20 UTC by Andrew Crouthamel
Modified: 2018-02-14 21:30 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Discover sources list showing missing source URL and details. (294.75 KB, image/png)
2018-02-14 20:20 UTC, Andrew Crouthamel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Crouthamel 2018-02-14 20:20:09 UTC
Created attachment 110666 [details]
Discover sources list showing missing source URL and details.

The details of the sources in the Settings view is now missing. Please see attached screenshot. I only noticed this after adding VirtualBox to my sources.list (deb https://download.virtualbox.org/virtualbox/debian xenial contrib). So I don't know if that caused it, or it was like this before and I just didn't check before then.

Current versions:
KDE Plasma Version: 5.12.1
KDE Frameworks Version: 5.43.0
Qt Version: 5.9.3
Kernel Version 4.13.0-32-generic
OS Type: 64-bit
Comment 1 Nate Graham 2018-02-14 21:07:08 UTC
This was by design because before, the full string was unreadable and made the settings page look ugly and people hated it. Now for non-Ubuntu packages, we show the first part of the URL only, as seen in your screenshot for Flathub, and for Ubuntu packages, we try to synthesize a pretty string. But it looks like there are still some bugs to work out here.

About half of those "Xenial (main) entries are actually source packages, and will be marked appropriately once Neon gets a new PackageKit version: https://github.com/hughsie/PackageKit/pull/238

But beyond those, there are still two other bugs I can see:
- One of your repos is just ".". That shouldn't happen.
- Even with half of the repos correctly displaying as "Xenial (main) sources", it still won't be clear why they all have the same name. They should probably have the same kind of shortened URL as the flathub entry, or else the synthesized string  should be unique for each repo.

Can you please open two new targeted bugs, one for each of those issues?

(FWIW the full URL would be visible if my feature request for an edit button is implemented: Bug: 389768)
Comment 2 Aleix Pol 2018-02-14 21:20:51 UTC
Andrew, one thing we can look into is improving it upstream in PackageKit:
https://github.com/hughsie/PackageKit/blob/master/backends/aptcc/apt-sourceslist.cpp#L448
Comment 3 Andrew Crouthamel 2018-02-14 21:30:03 UTC
(In reply to Nate Graham from comment #1)
> This was by design because before, the full string was unreadable and made
> the settings page look ugly and people hated it. Now for non-Ubuntu
> packages, we show the first part of the URL only, as seen in your screenshot
> for Flathub, and for Ubuntu packages, we try to synthesize a pretty string.
> But it looks like there are still some bugs to work out here.
> 
> About half of those "Xenial (main) entries are actually source packages, and
> will be marked appropriately once Neon gets a new PackageKit version:
> https://github.com/hughsie/PackageKit/pull/238
> 
> But beyond those, there are still two other bugs I can see:
> - One of your repos is just ".". That shouldn't happen.
> - Even with half of the repos correctly displaying as "Xenial (main)
> sources", it still won't be clear why they all have the same name. They
> should probably have the same kind of shortened URL as the flathub entry, or
> else the synthesized string  should be unique for each repo.
> 
> Can you please open two new targeted bugs, one for each of those issues?
> 
> (FWIW the full URL would be visible if my feature request for an edit button
> is implemented: Bug: 389768)

Ah ok. I will make some more bugs :). Like you said in bullet #2, my one repo I added above (deb https://download.virtualbox.org/virtualbox/debian xenial contrib) now shows in the list at the bottom, as just "Xenial (contrib)". So there's no knowing it is the virtualbox one, since they have it named "contrib" instead of "virtualbox".