| Summary: | Save as defaults to encrypted with no way to not encrypt | ||
|---|---|---|---|
| Product: | [Applications] kmymoney | Reporter: | Jack <ostroffjh> |
| Component: | file | Assignee: | KMyMoney Devel Mailing List <kmymoney-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | ||
| Priority: | NOR | ||
| Version: | 5.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kmymoney/03831143604ffb5f49267fc5dfdde97bb7059866 | Version Fixed In: | 5.0.1 |
| Sentry Crash Report: | |||
|
Description
Jack
2018-02-14 18:16:56 UTC
Same behavior with git head 5.0 branch. However, there are a few things I missed with the initial report. Even though I cancel the save, by clicking "No" at the encrypted save warning, KMM actually does save the file unencrypted. So, I see two separate bugs, but both less important than it seemed at first. 1) there should be a way to tell KMM not to encrypt, either before you save at all, or on the save dialog. I realize we cannot add anything to the Frameworks file select dialog, and popping up an separate dialog first could seem annoying. However, if the KMM configuration is set to not encrypt, then it probably should not be made the default here, unless somehow explicitly requested. 2) on the warning pop-up a) the title (I just see "Store GPG enc...ed -- KMyMoney ?" is too wide for the window shown, and b) the buttons Yes and No might be correct for whether or not to save encrypted, but they do not indicate that saying "No" still saves unencrypted, it doesn't cancel the save, as I thought. I have changed this to a wishlist instead of bug, although I'm not really sure what the best change would be. (Perhaps as simple as changing the last sentence of the warning from "If unsuer, answer NO" to "If unsure, answer NO, and the file will be saved without encryption." Git commit 03831143604ffb5f49267fc5dfdde97bb7059866 by Thomas Baumgart. Committed on 16/02/2018 at 19:19. Pushed by tbaumgart into branch '5.0'. Allow to select keys during File/Save As Due to the change in the KDE file save dialog the additional widgets could not be inserted dynamically into the dialog as we did in KDE4. This has been solved by an additional dialog when GPG encryption has been enabled in the settings and is available. FIXED-IN: 5.0.1 GUI: M +1 -0 kmymoney/dialogs/CMakeLists.txt M +77 -88 kmymoney/dialogs/kgpgkeyselectiondlg.cpp M +15 -3 kmymoney/dialogs/kgpgkeyselectiondlg.h A +139 -0 kmymoney/dialogs/kgpgkeyselectiondlg.ui M +19 -89 kmymoney/kmymoney.cpp M +1 -6 kmymoney/kmymoney.h https://commits.kde.org/kmymoney/03831143604ffb5f49267fc5dfdde97bb7059866 |