| Summary: | No "Name" field in Add Review pop-up | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Nate Graham <nate> |
| Component: | discover | Assignee: | Aleix Pol <aleixpol> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | 5.12.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/discover/e9d77bab1f34585afef9a764f75914258a7bdc0f | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Nate Graham
2018-02-07 19:29:09 UTC
Seems it takes the name from your current user account. I discovered by this by accident when I posted a review from within my development VM, and produced a review for Okular written by "dev". Oops. Git commit e9d77bab1f34585afef9a764f75914258a7bdc0f by Aleix Pol. Committed on 12/02/2018 at 19:05. Pushed by apol into branch 'master'. Show the name that will be used Maybe we'd like to make it easy to modify? M +5 -0 discover/qml/ReviewDialog.qml M +2 -1 discover/qml/ReviewsPage.qml M +1 -1 libdiscover/ReviewsBackend/AbstractReviewsBackend.h M +6 -0 libdiscover/appstream/OdrsReviewsBackend.cpp M +1 -1 libdiscover/appstream/OdrsReviewsBackend.h https://commits.kde.org/discover/e9d77bab1f34585afef9a764f75914258a7bdc0f I think we do need to make it easy to change, or else we're just frustrating people who see a name they want to change but can't do it. Want another bug for that? Here is that bug: Bug 405935. |