| Summary: | Add review UI has unnecessary extra padding below the "Accept" button | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kirigami | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | 5.42.0 | ||
| Target Milestone: | Not decided | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kirigami/cf677c81c7ff5e3db424b6b6784f1050dea99d7f | Version Fixed In: | |
| Attachments: | Unnecessary extra padding under "Accept" button | ||
This is an issue in Kirgami. We can also see this in Kirgiami Gallery by going to the "Non Scrollable Page" and pressing the main action button. Needs investigation as for why. Git commit cf677c81c7ff5e3db424b6b6784f1050dea99d7f by Nathaniel Graham.
Committed on 14/02/2018 at 16:45.
Pushed by ngraham into branch 'master'.
Eliminate unnecessary bottom padding on OverlaySheets
Summary:
The OverlaySheet already incorporates topMargin and bottomMargin into its height calculation, so we don't need to add any extra padding.
Test Plan:
Tested with Discover's review input sheet.
Before:
{F5710938}
After:
{F5710940}
Also tested in Kirigami Gallery; all pop-ups I could find still looked good.
Reviewers: #kirigami, apol, mart
Reviewed By: #kirigami, mart
Subscribers: plasma-devel
Tags: #kirigami
Differential Revision: https://phabricator.kde.org/D10502
M +1 -1 src/controls/templates/OverlaySheet.qml
https://commits.kde.org/kirigami/cf677c81c7ff5e3db424b6b6784f1050dea99d7f
|
Created attachment 110414 [details] Unnecessary extra padding under "Accept" button See attached screenshot. We should either increase the size of the text field or reduce the size of the pop-up.