| Summary: | Option to close Spectacle after export or copy the screenshot to clipboard | ||
|---|---|---|---|
| Product: | [Applications] Spectacle | Reporter: | Patrick Silva <bugseforuns> |
| Component: | General | Assignee: | Boudhayan Gupta <me> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | nate |
| Priority: | NOR | Keywords: | usability |
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/spectacle/2b1c8bec0fd1ff6b929eca638264d0649270af5f | Version Fixed/Implemented In: | KDE Applications 18.04 |
| Sentry Crash Report: | |||
|
Description
Patrick Silva
2018-02-01 21:02:57 UTC
Yep, this is planned. See https://phabricator.kde.org/T7841 I've got a patch going through the review process that adds this feature for copy operations: https://phabricator.kde.org/D10301 Note that you will need to configure Klipper to accept image pastes (Right-click on Klipper icon in system tray > Configure Clipboard > Uncheck "Ignore Images"). Quit after export operations presents more of a challenge and will be done in a separate patch. Git commit 2b1c8bec0fd1ff6b929eca638264d0649270af5f by Nathaniel Graham.
Committed on 11/02/2018 at 21:25.
Pushed by ngraham into branch 'master'.
(3/3) add option to quit after save or copy operations
Summary:
Part 3 of 3 for {T7841}
FIXED-IN: KDE Applications 18.04
We add a checkbox visible on the main UI to quit Spectacle after save or copy operations. This yields the following benefits:
- We can remove the "Save & Exit" item from the split button
- Users gain the ability to have spectacle quit after copying the image to the clipboard
I tried to make the feature apply to Export operations as well, but that proved to be much more complicated and I decided to abandon that for now and do it later in a subsequent patch.
Test Plan:
{F5691970}
Tested in KDE Neon:
- With "Quit after Copy or Save" unchecked:
-- Save: image is saved
-- Save As: file save dialog shown, image is saved
-- Copy to Clipboard: message is shown, image is copied to clipboard
- With "Quit after Copy or Save" checked:
-- Save: notification shown, Spectacle quits, image is saved
-- Save As: file save dialog shown, notification shown, Spectacle quits, image is saved
-- Copy to Clipboard: image is copied to clipboard (if Klipper is set up to accept images), Spectacle quits
Reviewers: #spectacle, rkflx
Reviewed By: rkflx
Subscribers: rkflx
Differential Revision: https://phabricator.kde.org/D10301
M +11 -8 doc/index.docbook
M +7 -1 src/ExportManager.cpp
M +1 -1 src/ExportManager.h
M +28 -20 src/Gui/KSMainWindow.cpp
M +0 -1 src/Gui/KSMainWindow.h
M +8 -5 src/Gui/KSWidget.cpp
M +1 -0 src/Gui/KSWidget.h
M +13 -0 src/SpectacleConfig.cpp
M +3 -0 src/SpectacleConfig.h
https://commits.kde.org/spectacle/2b1c8bec0fd1ff6b929eca638264d0649270af5f
|