Summary: | Main window too narrow by default | ||
---|---|---|---|
Product: | [Applications] systemsettings | Reporter: | Nate Graham <nate> |
Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | epost.kde, veqz |
Priority: | NOR | Keywords: | usability |
Version: | 5.11.95 | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/systemsettings/19712a1d22b2b4055a0ff39bf57fa2fdd41388f3 | Version Fixed In: | 5.13.0 |
Description
Nate Graham
2018-01-29 20:58:01 UTC
Isn't the KCM supposed to be designed for (and should thus open as) 1024 px x 768 px anyway? Yeah, this ticket tracks a bug, not a bad design decision. I took a look last night but couldn't find where the size got set. I was pretty sleepy though, and I plan to re-investigate later. If anyone else here with more technical knowledge can also take a look, I would be most grateful! Git commit 19712a1d22b2b4055a0ff39bf57fa2fdd41388f3 by Scott Harvey. Committed on 09/05/2018 at 15:00. Pushed by sharvey into branch 'master'. Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width. Summary: Call `setMinimumSize()` at each run to enforce a minimum size. Any enlarged size will be saved and restored via the customary method of saving window geometry. Test Plan: - Compile systemsettings with patch - Launch system settings (systemsettings5) - Determine that window opens at an appropriate size. - Close System Settings and reopen; ensure size remains set To test small or rotated screen sizes: - Adjust display resolution to a size smaller than the standard target of 1024x700 - System settings window should launch with a margin on all sides (not monopolize entire screen space) Reviewers: ngraham, mart, davidedmundson, hein, #plasma Reviewed By: ngraham, davidedmundson, hein, #plasma Subscribers: davidedmundson, cfeck, zzag, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D12252 M +8 -3 app/SettingsBase.cpp https://commits.kde.org/systemsettings/19712a1d22b2b4055a0ff39bf57fa2fdd41388f3 |