| Summary: | Desired connections run away just before clicking the "connect" button or entering password | ||
|---|---|---|---|
| Product: | [Plasma] plasma-nm | Reporter: | Josef Kufner <jk> |
| Component: | applet | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | grave | CC: | adamantgarth, axel.braun, balazs, boris, bugs, bugseforuns, danne, germano.massullo, jgrulich, justin.zobel, kde, kolAflash, lukas.buehrer, me, nate, papjk3, philip, setpill, silvan.calarco, xgdgsc |
| Priority: | VHI | Keywords: | usability |
| Version: | 5.25.5 | ||
| Target Milestone: | --- | ||
| Platform: | Debian unstable | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-nm/commit/575e9e912b93b10b7fd337a5c100ac533b6ca4e2 | Version Fixed In: | 5.26 |
| Sentry Crash Report: | |||
| Attachments: |
nm-applet before and after update
attachment-30706-0.html |
||
|
Description
Josef Kufner
2018-01-16 12:46:07 UTC
*** Bug 398291 has been marked as a duplicate of this bug. *** *** Bug 401816 has been marked as a duplicate of this bug. *** Marking as confirmed as several other reports have been marked as duplicate against this one. *** Bug 427512 has been marked as a duplicate of this bug. *** If you're connected to network 'A' and want to connect to a VPN. You click the nm-applet hover over the 'connect' button for the VPN. Then IF you have more SSID networks "remembered" they will place themself between network 'A' and the VPN in the list, making the VPN move down the list. This update happens when you have started to click 'connect' for the VPN, but resulting in clicking 'connect' for network 'B'. Created attachment 132960 [details]
nm-applet before and after update
KDE Plasma version 5.20.2
KDE Frameworks ver 5.75.0
QT Version 5.15.1
See attachment for present behaviour.
Expected behaviour:
Don't rearrange the top items in the list.
*** Bug 419288 has been marked as a duplicate of this bug. *** *** Bug 427798 has been marked as a duplicate of this bug. *** Bumping to VHI as number of dupes increases and it affects more things (now the password field is affected too). *** Bug 429363 has been marked as a duplicate of this bug. *** *** Bug 428304 has been marked as a duplicate of this bug. *** *** Bug 424951 has been marked as a duplicate of this bug. *** I have the same issue (without VPN, just Wi-Fi) on Kubuntu 20.10. Is there a way (apart from voting) to change the priority of this issue? I'm really surprised this has been hanging here for almost 3 years. This makes Kubuntu totally unusable for my girlfriend and I'd guess for everyone else who relies on WiFi. It also really limits the options to find a good looking distro for newbies when KDE is not an option. (Troubleshooting and finding a workaround is not an option when trying to convince someone to switch from Windows to Linux. Internet has to work on first boot.) I agree that it's an annoying issue that needs to be fixed, but "makes Kubuntu totally unusable" strikes me as a slight exaggeration given that the workaround is to simply wait a few seconds first. :) Created attachment 134313 [details] attachment-30706-0.html Waiting didn't work for me, they kept jumping around. So yes, no internet means unusable in my case. Sent from my mobile On Thu, 24 Dec 2020, 17:44 Nate Graham, <bugzilla_noreply@kde.org> wrote: > https://bugs.kde.org/show_bug.cgi?id=389052 > > --- Comment #14 from Nate Graham <nate@kde.org> --- > I agree that it's an annoying issue that needs to be fixed, but "makes > Kubuntu > totally unusable" strikes me as a slight exaggeration given that the > workaround > is to simply wait a few seconds first. :) > > -- > You are receiving this mail because: > You voted for the bug. > You are on the CC list for the bug. (In reply to Boris from comment #15) > Created attachment 134313 [details] > attachment-30706-0.html > > Waiting didn't work for me, they kept jumping around. So yes, no internet > means unusable in my case. > > Sent from my mobile > > On Thu, 24 Dec 2020, 17:44 Nate Graham, <bugzilla_noreply@kde.org> wrote: > > > https://bugs.kde.org/show_bug.cgi?id=389052 > > > > --- Comment #14 from Nate Graham <nate@kde.org> --- > > I agree that it's an annoying issue that needs to be fixed, but "makes > > Kubuntu > > totally unusable" strikes me as a slight exaggeration given that the > > workaround > > is to simply wait a few seconds first. :) > > > > -- > > You are receiving this mail because: > > You voted for the bug. > > You are on the CC list for the bug. I don't know if this helps, but this issue does not occur when I switch to kde on my opensuse desktop where the network was already configured before installing kde. (It does happen when I boot from the kubuntu live usb on the same system.) (In reply to Boris from comment #16) > I don't know if this helps, but this issue does not occur when I switch to > kde on my opensuse desktop where the network was already configured before > installing kde. (It does happen when I boot from the kubuntu live usb on the > same system.) If you do not connect from the drop-down list, but go via the network management menu -> Create connection -> Wifi you can chose the SSID and enter the password. Not as comfortable as from the list, but a workaround Should be fixed or at least improved with https://invent.kde.org/plasma/plasma-nm/-/merge_requests/41. Improved but not fixed, methinks. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-nm/-/merge_requests/47 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-nm/-/merge_requests/48 *** Bug 447397 has been marked as a duplicate of this bug. *** Marking as Grave since this can and does cause you to send your password to the wrong network, where it could be sniffed and compromised. *** Bug 449666 has been marked as a duplicate of this bug. *** *** Bug 449666 has been marked as a duplicate of this bug. *** Crossposting this for visibility; There are two different bugs being discussed here. 1. The order of the items in the applet list changes based on signal strength, regardless of mouseover. This is this bug. The proper solution to this is to detect when an entry has mouseover, and make sure it is not reordered in that case. 2. The password entry field is associated with the nth item in the list rather than associated with the SSID. I reported this as bug 449666 which was (imho erroneously) marked as duplicate. The proper solution to this bug is to fix that association. Most notably, in practice this is different because **it's fine for an item to change order when it has keyboard focus**. Keyboard focus can be retained even when an item changes order. If you're in a place with dozens of SSIDs around, it is not possible to connect to the correct one using the applet, as the list is re-arranged all the time, and you've no chance to enter the password at that speed. As stated by others before, this can quickly become a security issue, as the password field keeps open, but suddenly belongs to the wrong entry - of whatever type. *** Bug 453598 has been marked as a duplicate of this bug. *** *** Bug 435430 has been marked as a duplicate of this bug. *** *** Bug 442749 has been marked as a duplicate of this bug. *** Wow...shall we light a candle for the (coming) 4th anniversary of this annoying bug? (In reply to Axel Braun from comment #31) > Wow...shall we light a candle for the (coming) 4th anniversary of this > annoying bug? This reminds me why I stopped filing bugs against KDE. *** Bug 459604 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-nm/-/merge_requests/153 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-nm/-/merge_requests/153 Git commit 9e5cdc3e4f0b83221310560f2e4966c7d5fa59bc by ivan tkachenko. Committed on 04/10/2022 at 10:06. Pushed by ratijas into branch 'master'. applet: Fix delayModelUpdates mode The delayModelUpdates write-only property was a workaround, but it didn't even work properly especially with multiple delegates (writers) per single shared variable. This patch promotes the concept into a model role, and turns the model's shared property into readonly aggregated state. This should fix most of the cases when a connection would suddenly teleport away or even replaced with another while typing in password. M +7 -9 applet/contents/ui/ConnectionItem.qml M +4 -1 applet/contents/ui/main.qml M +57 -17 libs/models/networkmodel.cpp M +14 -4 libs/models/networkmodel.h M +13 -0 libs/models/networkmodelitem.cpp M +4 -0 libs/models/networkmodelitem.h https://invent.kde.org/plasma/plasma-nm/commit/9e5cdc3e4f0b83221310560f2e4966c7d5fa59bc Git commit 6a6cbe10c9eaabf6bcd8ae2b12df7f0ea6903cc1 by ivan tkachenko. Committed on 04/10/2022 at 10:06. Pushed by ratijas into branch 'master'. applet: Block all role changes while in delayModelUpdates mode Practically all roles are accounted for when comparing connections in downstream sort-filter proxy model. Let's block all roles from propagating changes while scan delay is requested to avoid surprises. Partially helps, but not fully fixes: M +1 -3 libs/models/networkmodel.cpp https://invent.kde.org/plasma/plasma-nm/commit/6a6cbe10c9eaabf6bcd8ae2b12df7f0ea6903cc1 Git commit d83674e5ed171e590223a2fc0b6d49da09e245dc by ivan tkachenko. Committed on 04/10/2022 at 12:05. Pushed by ratijas into branch 'Plasma/5.26'. applet: Block all role changes while in delayModelUpdates mode Practically all roles are accounted for when comparing connections in downstream sort-filter proxy model. Let's block all roles from propagating changes while scan delay is requested to avoid surprises. Partially helps, but not fully fixes: (cherry picked from commit 6a6cbe10c9eaabf6bcd8ae2b12df7f0ea6903cc1) M +1 -3 libs/models/networkmodel.cpp https://invent.kde.org/plasma/plasma-nm/commit/d83674e5ed171e590223a2fc0b6d49da09e245dc Git commit 575e9e912b93b10b7fd337a5c100ac533b6ca4e2 by ivan tkachenko. Committed on 04/10/2022 at 12:05. Pushed by ratijas into branch 'Plasma/5.26'. applet: Fix delayModelUpdates mode The delayModelUpdates write-only property was a workaround, but it didn't even work properly especially with multiple delegates (writers) per single shared variable. This patch promotes the concept into a model role, and turns the model's shared property into readonly aggregated state. This should fix most of the cases when a connection would suddenly teleport away or even replaced with another while typing in password. (cherry picked from commit 9e5cdc3e4f0b83221310560f2e4966c7d5fa59bc) M +7 -9 applet/contents/ui/ConnectionItem.qml M +4 -1 applet/contents/ui/main.qml M +57 -17 libs/models/networkmodel.cpp M +14 -4 libs/models/networkmodel.h M +13 -0 libs/models/networkmodelitem.cpp M +4 -0 libs/models/networkmodelitem.h https://invent.kde.org/plasma/plasma-nm/commit/575e9e912b93b10b7fd337a5c100ac533b6ca4e2 > > Wow...shall we light a candle for the (coming) 4th anniversary of this
> > annoying bug?
>
> This reminds me why I stopped filing bugs against KDE.
And that reminds me why I started fixing them 😬
|