| Summary: | Scrolling beyond boundaries with PgUp/PgDn causes artifacts | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Fabian Vogt <fabian> |
| Component: | discover | Assignee: | Aleix Pol <aleixpol> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/discover/124dd510d5a42f6f98f8134b5ddffd930547ec1e | Version Fixed In: | |
|
Description
Fabian Vogt
2018-01-09 19:05:24 UTC
Whoa! Can confirm with git master. Really weird behavior. Git commit f0dc351a2605b8e5695dd1f5c4a40aef6664881e by Aleix Pol. Committed on 10/01/2018 at 02:39. Pushed by apol into branch 'master'. Make the sources page header a page header rather than a list header M +49 -51 discover/qml/SourcesPage.qml https://commits.kde.org/discover/f0dc351a2605b8e5695dd1f5c4a40aef6664881e Git commit 17c61127db1d6c60e5269e62d7d20cf77a95ef36 by Aleix Pol. Committed on 10/01/2018 at 02:40. Pushed by apol into branch 'master'. Don't scroll up if on top, don't scroll down if at the bottom M +6 -0 discover/qml/DiscoverPage.qml https://commits.kde.org/discover/17c61127db1d6c60e5269e62d7d20cf77a95ef36 Doesn't work when the scroll position is not aligned to the end/beginning or a multiple of the page height. It looks like contentY must not ever go outside of bounds as returnToBounds doesn't have the desired effect. Git commit 204467d49e83c53158e185e73fe6c44c45bd9c43 by Aleix Pol. Committed on 10/01/2018 at 17:45. Pushed by apol into branch 'master'. Add some extra checks to improve the keyboard scrolling M +10 -4 discover/qml/DiscoverPage.qml https://commits.kde.org/discover/204467d49e83c53158e185e73fe6c44c45bd9c43 Git commit 124dd510d5a42f6f98f8134b5ddffd930547ec1e by Fabian Vogt. Committed on 10/01/2018 at 19:25. Pushed by fvogt into branch 'master'. Fix scrolling with keyboard Replace the previous guards with a single statement. M +3 -16 discover/qml/DiscoverPage.qml https://commits.kde.org/discover/124dd510d5a42f6f98f8134b5ddffd930547ec1e |