Bug 388691

Summary:	Problems with "edit-select-none" icon and "edit-select" icon?
Product:	[Plasma] Oxygen	Reporter:	Toni Asensi Esteve <toni.asensi>
Component:	icons	Assignee:	pinheiro <nuno>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kubry
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Kubuntu
OS:	Linux
Latest Commit:	https://commits.kde.org/oxygen-icons5/857400cb1a51f2287e4b6b285bba0f897066a6f7	Version Fixed In:
Sentry Crash Report:

Description Toni Asensi Esteve 2018-01-08 19:15:38 UTC

As it is seen in https://bugs.kde.org/show_bug.cgi?id=372964 , it seems that nowadays:
- Oxygen does not have an "edit-select-none" icon, which Breeze has.
- Oxygen has an "edit-select" icon that shows only a generic image of a mouse arrow, unlike its Breeze equivalent, which shows a mouse arrow and a distinctive little circle.

Note: Using e.g. Plasma 4 under Kubuntu 14.04: there weren't those problems, as it can be seen in:
    https://bugsfiles.kde.org/attachment.cgi?id=102452
unlike what is seen nowadays:
    https://bugsfiles.kde.org/attachment.cgi?id=102453

Thank you for Oxygen!

Comment 1 andreas 2018-02-07 01:18:16 UTC

Git commit 857400cb1a51f2287e4b6b285bba0f897066a6f7 by andreas kainz.
Committed on 07/02/2018 at 01:17.
Pushed by andreask into branch 'master'.

Add edit-select-none to Oxygen for Krusader

A  +-    --    16x16/actions/edit-select-none.png
A  +-    --    22x22/actions/edit-select-none.png
A  +-    --    32x32/actions/edit-select-none.png
A  +-    --    48x48/actions/edit-select-none.png
A  +-    --    scalable/actions/small/16x16/edit-select-none.svgz
A  +-    --    scalable/actions/small/22x22/edit-select-none.svgz
A  +-    --    scalable/actions/small/32x32/edit-select-none.svgz
A  +-    --    scalable/actions/small/48x48/edit-select-none.svgz

https://commits.kde.org/oxygen-icons5/857400cb1a51f2287e4b6b285bba0f897066a6f7

Comment 2 Ganton 2018-02-08 09:47:12 UTC

A very good improvement! Now Oxygen icons have an "edit-select-none" icon, as Breeze!

Comment 3 Nikita Melnichenko 2018-04-22 22:03:40 UTC

Git commit 94ea5b69af14620abd4a44a13240ca9b2749641b by Nikita Melnichenko.
Committed on 22/04/2018 at 22:00.
Pushed by melnichenko into branch 'master'.

Refactored and unified icon rendering, implemented per-icon fallback logic

Merge branch 'fix-missing-icons'

The merged branch contains implementation of per-icon fallback logic:
1. Search icon in the active icon theme — if found, use it.
2. Search it in the icon theme that is specified in Krusader config — if found, use it.
3. Search it in Breeze or Oxygen (in case any of these installed) — if found, use it.
4. Otherwise use a default "icon-missing" icon bundled with Krusader.

FIXED: [ 372964 ] At least one Oxygen icon in Krusader is not correctly seen (using Kubuntu 16.04)
Related: bug 372964, bug 372966, bug 376699, bug 381676, bug 386554, bug 391899

FIXED: [ 372966 ] Some icons are not seen using a plain Ubuntu (not Kubuntu) 16.04

Differential Revision: https://phabricator.kde.org/D10352

M  +11   -10   krusader/kractions.cpp
M  +2    -8    krusader/krusader.cpp

https://commits.kde.org/krusader/94ea5b69af14620abd4a44a13240ca9b2749641b