Bug 388622

Summary: Breeze SDDM theme should be more readable when using wallpapers
Product: [Plasma] plasmashell Reporter: RaitaroH <RaitaroHikami>
Component: Global Theme packagesAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: anditosan1000, bugseforuns, gamunu.balagalla, i, kde, nate, plasma-bugs, samrog131, simonandric5
Priority: NOR Keywords: usability
Version: masterFlags: kde: VisualDesign+
Target Milestone: 1.0   
Platform: Neon   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=369676
Latest Commit: Version Fixed In: 5.13
Sentry Crash Report:
Attachments: Wallpaper example.

Description RaitaroH 2018-01-06 17:36:07 UTC
Created attachment 109712 [details]
Wallpaper example.

Looking for this bug I found this:
https://bugzilla.redhat.com/show_bug.cgi?id=1449152

My problem is the same. If I am going to change the background color to an wallpaper then the icons and text are really hard to read, that is if the wallpaper isn't very dark.

Maybe some shadows for the text and icons will solve the problem. For example I have conky set up with "draw-shades" which acts like "text-shadow" in CSS. The text is white but it looks good with any wallpaper.
Comment 1 Nate Graham 2018-01-06 22:17:55 UTC
KDM is obsolete, and SDDM bug reports are tracked at https://github.com/sddm/sddm. However this request is for the Breeze SDDM theme, so moving it there.
Comment 2 David Edmundson 2018-01-06 23:22:57 UTC
@Nate we've been putting anything that comes from plasma-workspace/lookandfeel here. That duristriction is a bit messy.

As for the bug:

The old lockscreen handled with the half opactiy black stripes, but this was explicitly removed in the new design which came from the VDG. A fix needs to come from there also.
Comment 3 Nate Graham 2018-01-07 01:15:42 UTC
Thanks, we're currently discussing this.
Comment 4 Rog131 2018-01-08 08:00:59 UTC
I solved the readability problem by moving the texts to the sliding semitransparent cover.

YouTube preview: https://youtu.be/04X4cb9XTkg

KDE Store: https://store.kde.org/p/1174674/
Comment 5 Rog131 2018-01-08 08:07:29 UTC
The lock screen has same problem: Bug 369676 - White lockscreen text's readability depends on background - https://bugs.kde.org/show_bug.cgi?id=369676
Comment 6 Gamunu Balagalla 2018-02-17 05:10:19 UTC
This problem goes away if there's a way to do custom theming. It would be nice to have the lockscreen to be in harmony with the login screen (SDDM).
Comment 7 Nate Graham 2018-03-16 16:45:48 UTC
A proposed new design that VDG is iterating on can be found in Bug 369676.

We won't be able to support arbitrary user-specified themes since the login screen has to be able to run independently of any individual user's settings, but we could at least make it consistent with the default lock screen look.
Comment 8 Rog131 2018-03-16 17:21:29 UTC
(In reply to Gamunu Balagalla from comment #6)
> This problem goes away if there's a way to do custom theming. It would be
> nice to have the lockscreen to be in harmony with the login screen (SDDM).

Could you tell what do you mean 'custom theming' ?

I have edited both the SDDM greeter and the lock screen.

Result is: From Breeze Slider 2 SDDM theme to Breeze Custom Lock.mp4 - https://youtu.be/rCDBdGe8va0

All components are available from the KDE store to custom the your system.

- Breeze Slider 2 SDDM theme: https://store.kde.org/p/1222217/
- ImageSplash: https://store.kde.org/p/1173958/
- Video wallpaper: https://store.kde.org/p/1213488/
- Breeze Custom Lock Screen: https://store.kde.org/p/1216681/
Comment 9 Marco Martin 2018-04-22 14:41:19 UTC
Git commit 448455c3c937cebc1358dc417b280b0008a4c196 by Marco Martin.
Committed on 22/04/2018 at 14:41.
Pushed by mart into branch 'master'.

fade to blur when the login box appears

Summary:
for both lockscreen and login screen:

* display the wallpaper and the clock with a shadow by default
* at the first mouse or keyboard input, make the input fields appear
* the actual controls appear pretty fast
* the wallpaper starts to blur, desaturate and fade to darker
* after 10 seconds make the controls disappear again

* as soon as anything is written in the password field never fade out the controls
* if the virtual keyboard is open, never fade out the controls
* if anything is pushed on the stack, like "switch user", never fade the controls
* Esc clears the field and makes controls disappear (closing keyboard if needed)

the fade won't happen if the background is a simple color
Related: bug 369676
FIXED-IN: 5.13

Depends on D12314

Recommended D11309 and D11308 to change the default wallpaper to plasma wallpaper

Test Plan: tested the behavior of all the above points

Reviewers: #plasma, #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: zzag, abetts, davidedmundson, ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D11928

M  +4    -2    lookandfeel/contents/components/Clock.qml
M  +0    -1    lookandfeel/contents/components/SessionManagementScreen.qml
A  +182  -0    lookandfeel/contents/components/WallpaperFader.qml     [License: GPL (v2)]
M  +81   -13   lookandfeel/contents/lockscreen/LockScreenUi.qml
M  +2    -0    sddm-theme/Login.qml
M  +308  -236  sddm-theme/Main.qml

https://commits.kde.org/plasma-workspace/448455c3c937cebc1358dc417b280b0008a4c196
Comment 10 Rog131 2018-05-28 14:11:18 UTC
*** Bug 394791 has been marked as a duplicate of this bug. ***