Bug 388295

Summary:	CMake doesn't warn if Flatpak dev packages aren't installed
Product:	[Applications] Discover	Reporter:	Nate Graham <nate>
Component:	discover	Assignee:	Aleix Pol <aleixpol>
Status:	VERIFIED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	5.11.4
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/discover/01deaa8cf7b89725c3bc5b59fb8f58069e82774a	Version Fixed/Implemented In:
Sentry Crash Report:

Description Nate Graham 2017-12-28 16:03:18 UTC

Discover's CMake doesn't currently warn if the Flatpak dev packages aren't installed (libflatpak-dev on Ubuntu-based distros); instead it silently doesn't build the Flatpak backend libraries.

Comment 1 Aleix Pol 2017-12-28 16:24:21 UTC

Git commit 01deaa8cf7b89725c3bc5b59fb8f58069e82774a by Aleix Pol.
Committed on 28/12/2017 at 16:20.
Pushed by apol into branch 'master'.

Warn if building flatpak is enabled but some dependencies aren't found

M  +5    -0    CMakeLists.txt
M  +2    -0    libdiscover/backends/CMakeLists.txt

https://commits.kde.org/discover/01deaa8cf7b89725c3bc5b59fb8f58069e82774a

Comment 2 Nate Graham 2017-12-28 16:34:56 UTC

Confirmed, thanks for the super quick fix!