Summary: | Folder view should not allow duplicated file deletion dialog | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Patrick Silva <bugseforuns> |
Component: | Folder | Assignee: | Eike Hein <hein> |
Status: | CONFIRMED --- | ||
Severity: | normal | CC: | capitaine.kirk, meven29, nate, plasma-bugs |
Priority: | NOR | Keywords: | usability |
Version: | 5.27.4 | ||
Target Milestone: | 1.0 | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Patrick Silva
2017-12-17 13:46:42 UTC
Can confirm with Plasma 5.11.4 on Kubuntu 17.10. The dialog isn't modal, and initiating a second delete action opens a new dialog instead of bringing focus to the current one. confirmed on my Kubuntu 17.10. another dialog appears instead of bringing back the focus on the current one. The issue boils down to library KIO::JobUiDelegate not supporting QWindow as parent window, but requiring a QWidget instead, but since the folder view is in QtQuick/QML land that is not possible from there. We need to make KIO::JobUiDelegate and KMessageBox work with QWindow to fix this properly. Maybe wait to make a a library breakage : changing : KIO::JobUiDelegate::setWindow(Qwidget *window) to KIO::JobUiDelegate::setWindow(QWindow *window) Which should be easy for users to port, since QWidget has a nice windowHandle function to get any QWigets parent window. Removing junior-job as library work is not an easy path for first contribution. |