| Summary: | Screenshot pop-up has an extra margin on the side or top if window dimensions aren't just right | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Nate Graham <nate> |
| Component: | discover | Assignee: | Aleix Pol <aleixpol> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | 5.11.4 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/discover/0c2db42b943380782cc3c338902b2c16d098036e | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
Extra margin on side and top when window is very wide or somewhat tall
Now screenshows are never scaled down to match the window width |
||
Looks fixed as of the recent screenshot pop-up improvements. Nah sorry, seeing this again with current git master. Git commit 4efed77684fc0fca8d26a6e9076a3a3d3b634dd3 by Aleix Pol. Committed on 29/12/2017 at 14:06. Pushed by apol into branch 'master'. Don't show white space around the screenshot when it doesn't fit M +2 -1 discover/qml/ApplicationScreenshots.qml https://commits.kde.org/discover/4efed77684fc0fca8d26a6e9076a3a3d3b634dd3 Created attachment 109579 [details]
Now screenshows are never scaled down to match the window width
Well that fixed the top margin issue, but now screenshots are never scaled down to match the window width.
Git commit 0c2db42b943380782cc3c338902b2c16d098036e by Aleix Pol. Committed on 29/12/2017 at 15:26. Pushed by apol into branch 'master'. Also take width into account M +1 -1 discover/qml/ApplicationScreenshots.qml https://commits.kde.org/discover/0c2db42b943380782cc3c338902b2c16d098036e Thanks, works great now! |
Created attachment 109330 [details] Extra margin on side and top when window is very wide or somewhat tall When the screenshot pop-up is open, if the window dimensions aren't exactly right, there is an extra margin on either the side or the top. The screen recording I've attached illustrates the problem better than I can explain it. This is pretty easy to see if the window is taller than it is wide, since most screenshots are in the landscape orientation.