| Summary: | Elegant theme: Selected frame colors swapped [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Alexander Potashev <aspotashev> |
| Component: | Plugin-Generic-HTMLGallery | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, velurimithun38 |
| Priority: | NOR | Flags: | caulier.gilles:
Junior_Jobs+
|
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/digikam/c7a1cccb53b8f85840a439801846148046be182b | Version Fixed/Implemented In: | 6.0.0 |
| Sentry Crash Report: | |||
| Attachments: |
patch to fix inverted colors
selectedFrameColor for background-color selectedFrameBorderColor for border |
||
Created attachment 109141 [details]
patch to fix inverted colors
If you look well in CSS customization of Elegant theme, more than one properties are inverted. See my patch for details.
(In reply to caulier.gilles from comment #1) > Created attachment 109141 [details] > patch to fix inverted colors > > If you look well in CSS customization of Elegant theme, more than one > properties are inverted. See my patch for details. Thanks Gilles! "1px solid" should always appear in the "border:" attribute, you mistakenly introduced some "background-color: 1px solid [...]" lines in your patch. Alexander, What's the right patch well ? I'm not sure to understand Gilles Caulier Created attachment 111829 [details]
selectedFrameColor for background-color
selectedFrameBorderColor for border
(In reply to Veluri Mithun from comment #4) > Created attachment 111829 [details] > give selectedFrameColor for a:hover 'background-color' and selectedFrameBorderColor for a:hover 'border' Git commit c7a1cccb53b8f85840a439801846148046be182b by Human Dynamo. Committed on 05/04/2018 at 04:48. Pushed by cgilles into branch 'master'. apply patch #111829 from Veluri Mithun to fix Elegan theme from image gallery FIXED-IN: 6.0.0 M +4 -4 core/data/htmlgallery/themes/elegant/template.xsl https://commits.kde.org/digikam/c7a1cccb53b8f85840a439801846148046be182b |
In the HTML export "Elegant" theme - the variable named selectedFrameColor has effect on the border, - the variable named selectedFrameBorderColor has effect on the background color. Should be the other way around. See in digikam/data/htmlgallery/themes/elegant/template.xsl: #content li a { background-color: <xsl:value-of select="$frameColor"/>; border: 1px solid <xsl:value-of select="$frameBorderColor"/>; } #content li a:hover { border: 1px solid <xsl:value-of select="$selectedFrameColor"/>; background-color: <xsl:value-of select="$selectedFrameBorderColor"/>; }