Bug 387470

Summary: Comments unreadable in scripter under default theme
Product: [Applications] krita Reporter: Brendan <bunf2014>
Component: ScriptingAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version First Reported In: 4.0 pre-alpha   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: https://commits.kde.org/krita/f095d09f46f401e3177a005c2712fc014d956c44 Version Fixed/Implemented In:
Sentry Crash Report:

Description Brendan 2017-11-30 13:49:26 UTC 
Python hash comments:
# a comment
are rendered in a dark green against a dark grey in the default krita colour scheme. The colours make the comments very difficult to read. 

Triple quote comments:
""" a comment"""
are only slightly better, being dark pink
Comment 1 wolthera 2017-12-04 16:35:57 UTC 
Git commit f095d09f46f401e3177a005c2712fc014d956c44 by Wolthera van Hövell tot Westerflier.
Committed on 04/12/2017 at 16:32.
Pushed by woltherav into branch 'master'.

Add background and foreground to the style syntax.

It technically doesn't belong with the style syntax, but from
a color palette design point of view, it does belong there
because it isn't possible to get always contrasting colors if you
cannot control which background to use. Leading to sometimes unreadable
comments or syntax highlighting.

M  +1    -1    plugins/extensions/pykrita/plugin/plugins/scripter/ui_scripter/actions/settingsaction/settingsdialog.py
M  +10   -2    plugins/extensions/pykrita/plugin/plugins/scripter/ui_scripter/actions/settingsaction/syntaxstylescombobox.py
M  +14   -4    plugins/extensions/pykrita/plugin/plugins/scripter/ui_scripter/editor/pythoneditor.py
M  +4    -0    plugins/extensions/pykrita/plugin/plugins/scripter/ui_scripter/syntax/syntaxstyles.py
M  +5    -1    plugins/extensions/pykrita/plugin/plugins/scripter/uicontroller.py

https://commits.kde.org/krita/f095d09f46f401e3177a005c2712fc014d956c44