| Summary: | Layers and Reviews categories use the same icon ("draw-freehand") | ||
|---|---|---|---|
| Product: | [Applications] okular | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Okular developers <okular-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aacid, luigi.toscano, simonandric5 |
| Priority: | NOR | ||
| Version: | 1.1.3 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: | Both categories use the same icon | ||
Patch at https://phabricator.kde.org/D9043 And you commited your patch, only to master and forgot to close this bug. Please pay more attention to detail when developing. Bugfixes like this go to stable branches. I'll close the bug manually. Sorry, I thought the bug would get closed automatically because I added "BUG: 387424" to the pPhabricator revision. In general, should I always ask which branch to commit to, or always commit to the latest stable branch and then merge to master, or do something else? (In reply to Nate Graham from comment #3) > Sorry, I thought the bug would get closed automatically because I added > "BUG: 387424" to the pPhabricator revision. The line is "Summary: BUG: 387424", and that's probably why it was not parsed. > In general, should I always ask which branch to commit to, or always commit > to the latest stable branch and then merge to master, or do something else? As Albert wrote: bugfixes (no features, no string changes (but exceptions are possible), etc) can go directly to the stable branch (and then merge to master). Anything else to master. Ok, thanks! |
Created attachment 109106 [details] Both categories use the same icon See attached screenshot. Will submit a patch soon.