| Summary: | PlasmaComponents2.ComboBox in RTL shows wrong the selected item | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] libplasma | Reporter: | Michail Vourlakos <mvourlakos> |
| Component: | components | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | 5.40.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-framework/71f8f16fea15973bdf98a621610b7e2b891dfa77 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Michail Vourlakos
2017-11-28 19:37:53 UTC
More info about that...
The alignment of the Selected option in Combobox is identified by the language used for that specific option... This is wrong in my opinion because if the user has a list of options containing both English words and RTL ones then the selected text is moved for some of them to the left and for some of them to the right.
In my opinion a check of type:
> Qt.application.layoutDirection === Qt.RightToLeft
should be sufficient
just checked that this issue is not appearing with QML standard ComboBox so this is plasma components issue. Git commit 71f8f16fea15973bdf98a621610b7e2b891dfa77 by Michail Vourlakos. Committed on 05/12/2017 at 17:13. Pushed by mvourlakos into branch 'master'. [RTL] - align properly the selected text for RTL Summary: --align selected text correctly for PlasmaComponents2.ComboBox taking into account RTL. Test Plan: use ComboBoxes in RTL and LTR in order to check a proper behavior Reviewers: #plasma, davidedmundson Reviewed By: #plasma, davidedmundson Subscribers: broulik, plasma-devel, #frameworks Tags: #plasma, #frameworks Differential Revision: https://phabricator.kde.org/D9126 M +1 -0 src/declarativeimports/plasmastyle/ComboBoxStyle.qml https://commits.kde.org/plasma-framework/71f8f16fea15973bdf98a621610b7e2b891dfa77 |