Summary: | Cannot create New Folder | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Christoph Feck <cfeck> |
Component: | general | Assignee: | David Faure <faure> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bugseforuns, elvis.angelaccio, hein, kdelibs-bugs, nate, pgkos.bugzilla, plasma-bugs, pulfer, simonandric5 |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kio/298c0e734efdd8a7b66a531959e3fb5357a6495d | Version Fixed In: | 5.41 |
Description
Christoph Feck
2017-11-18 15:50:34 UTC
The commit referenced in comment #1 fixed it, merci. Can we mark this as resolved, then? Yes. It's not really fixed, since I have the same problem while trying to create any item (not limited on folders) on the KDE-Desktop, such as a new file, folder or link. Actions are refused with the comment of invalid url. In Dolphin it works after applying the latest patch, but not on the desktop. Right, it seems Folder View is still affected :/ foldermodel.cpp uses KNewFileMenu just like dolphin does, so I don't really understand why it works in dolphin but not in plasma. Re-assigning to plasma. It seems the desktop ioslave needs to be adjusted (you can reproduce the bug also in dolphin if you go to the desktop:/ URL). This bug is in KIO, not in Plasma (or the ioslave). Patch: https://phabricator.kde.org/D9029 Git commit 298c0e734efdd8a7b66a531959e3fb5357a6495d by Eike Hein. Committed on 28/11/2017 at 10:50. Pushed by hein into branch 'master'. Fix creating a directory via KNewFileMenu+KIO::mkpath on Qt 5.9.3+ Summary: f62768d04652 in qtbase.git introduced a behavior change in QUrl causing it to reject URLs with a path of "//foo" (note the double slash) as invalid. Both KNewFileMenu and KIO::mkpath contained code following this pattern: url.path() + '/' + name This is a bad mix with forwarding slaves like kio_desktop, which translate a top-level path of / to some other URL: (desktop:)/ + / + foo = //foo This patch addresses the two instances of this by wrapping the string building in QDir::cleanPath, which I think is the shortest and most readable way to go. 2353119aae8f in kio.git (D8836) was another commit fixing fallout from this Qt change. Is unlikely this patch will be the last one. I suspect many other variations of this problem lurk about the codebase. Reviewers: dfaure, thiago, elvisangelaccio Subscribers: #frameworks Tags: #frameworks Differential Revision: https://phabricator.kde.org/D9029 M +2 -1 src/core/mkpathjob.cpp M +1 -1 src/filewidgets/knewfilemenu.cpp https://commits.kde.org/kio/298c0e734efdd8a7b66a531959e3fb5357a6495d Creating a new folder on the desktop is now possible afer applying the patch, but I still run into the same malformed URL message if I try to create a new file, or a link on the desktop. Should I file a new bug report for this issue, or you prefer to re-open this one? I'll let the KIO maintainer decide. After demonstrating that it's a KIO issue and not in FV, I'd like the KIO folks to do the next steps as I'll be travelling starting tomorrow and all next week and can't work on this in a timely manner. *** Bug 387529 has been marked as a duplicate of this bug. *** > Should I file a new bug report for this issue, or you prefer to re-open this > one? Now we also have https://bugs.kde.org/show_bug.cgi?id=387529 but it's marked as RESOLVED DUPLICATE. IMHO, we should have at least one of these bugs open until the issue is fixed. |