| Summary: | Scrollview-within-a-scrollview paradigm is sub-optimal | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Nate Graham <nate> |
| Component: | discover | Assignee: | Aleix Pol <aleixpol> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/discover/732a0ffb2ab0cac9778ea490098ddad02ece824d | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | Screenshot | ||
Proof-of-concept patch available at https://phabricator.kde.org/D8869 The patch may not be quite the right way to implement this change, but hopefully it illustrates the general idea. Git commit 732a0ffb2ab0cac9778ea490098ddad02ece824d by Nathaniel Graham.
Committed on 17/11/2017 at 16:14.
Pushed by ngraham into branch 'master'.
Don't use a scrollview to display package changelogs
Summary:
Don't put the package changelogs in a scrollview, because it introduces some usability issues (see the bug for details).
Also change the "Open" button to day "More Information..." since it wasn't clear what you were opening.
Test Plan:
Tested in KDE Neon. Package changelogs are now fully visible without being in a tiny scrollview:
{F5495553}
Reviewers: #discover_software_store, apol
Reviewed By: #discover_software_store, apol
Subscribers: abetts, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8869
M +5 -8 discover/qml/UpdatesPage.qml
https://commits.kde.org/discover/732a0ffb2ab0cac9778ea490098ddad02ece824d
|
Created attachment 108916 [details] Screenshot When using Discover to perform software updates, each package can be clicked to display the package's changelog (if available). However the changelog is embedded within a scrollview, which leads to a situation where there are scrollviews within a larger scrollview. This causes two usability issues: - The scrollview is short and wide, making it hard to actually read the content - Your cursor can easily find itself above a package changelog scrollview and get its focus stolen when you are reying to scroll the list of packages I recommend taking the package changelogs out of their scrollviews and just display the full content in a non-scrolling view as tall as necessary if the user clicks on it.