| Summary: | Incorrect name for pc file an library in it | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-activities-stats | Reporter: | rezso <rezso> |
| Component: | general | Assignee: | Ivan Čukić <ivan.cukic> |
| Status: | CONFIRMED --- | ||
| Severity: | normal | CC: | cfeck, christophe, groot, plasma-bugs-null, simonandric5 |
| Priority: | NOR | ||
| Version First Reported In: | 5.40.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
|
Description
rezso
2017-11-15 02:45:52 UTC
Note that KActivities (the other framework) **also** contains a .pc file, which is called `libKActivities.pc` .. so that's a similarly wrongly-named file. The description in both files names them wrongly, the URL could be upgraded to https, and in my installed (to a DESTDIR) version of the framework, the *libs* line looks like this:
```
Libs: -Llib -lKActivitiesStats
```
That does not seem like a useful setting for the -L flag; other pc files from KDE Frameworks provide a full (prefix) path. The *requires* line is also missing Qt5Core.
So there's more to fix than just the name.
OK, renaming the .pc files in these 2 repos wouldn't be source compatible (the impact in null as these 2 files are unusable in their current state) Git commit 3a24cde223aeeaf3b50dc3054d9ba12eb39a0e0e by Christophe Giboudeaux. Committed on 29/11/2017 at 08:23. Pushed by cgiboudeaux into branch 'master'. Start fixing libKActivitiesStats.pc: - Add a working version string, - Require Qt5Core, - Use the correct library name when linking M +3 -3 src/libKActivitiesStats.pc.cmake https://commits.kde.org/kactivities-stats/3a24cde223aeeaf3b50dc3054d9ba12eb39a0e0e I'm not closing the report. I didn't rename the file (yet). I need more opinions first. |