Bug 386850

Summary:	Kirigami apps have dark labels when using dark theme
Product:	[Frameworks and Libraries] frameworks-kirigami	Reporter:	Jan Grulich <jgrulich>
Component:	general	Assignee:	Marco Martin <notmart>
Status:	RESOLVED NOT A BUG
Severity:	normal	CC:	aleixpol, jgrulich
Priority:	NOR
Version First Reported In:	Master
Target Milestone:	Not decided
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Screenshot of plasma discover

Description Jan Grulich 2017-11-13 11:02:29 UTC

Created attachment 108835 [details]
Screenshot of plasma discover

When using a dark theme I can barely see some labels in Kirigami apps. This is most visible when using Plasma Discover. There is also a bug 384638 opened for system settings which I think is caused by the same problem.

Comment 1 Marco Martin 2017-11-13 11:05:42 UTC

hmm, i'm pretty sure our labels colors are ok, does discover does something about labels colors?

Comment 2 Jan Grulich 2017-11-13 11:09:58 UTC

You can ignore this, I should have checked the discover source code first as those invisible labels are actually QQC2.Label.

Comment 3 Jan Grulich 2017-11-13 11:10:50 UTC

It looks correct when I set:
color: Kirigami.Theme.textColor

Comment 4 Marco Martin 2017-11-13 11:29:37 UTC

(In reply to Jan Grulich from comment #3)
> It looks correct when I set:
> color: Kirigami.Theme.textColor

qqc2.label should also have the correct color, if the proper style, qqc2-desktop-style is used

Comment 5 Jan Grulich 2017-11-13 11:37:06 UTC

You are right. I installed qqc2-desktop-style and that fixed my issue. We apparently don't have this packaged in Fedora yet.