Summary: | Search box cropped when Dolphin window is not wide enough | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | Alexander Potashev <aspotashev> |
Component: | search | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dagobertram, mail, nate |
Priority: | NOR | Keywords: | usability |
Version First Reported In: | 17.04.1 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/system/dolphin/-/commit/4102ccb80457eea44ea280f0ace2a419602bc34b | Version Fixed In: | 25.08 |
Sentry Crash Report: |
Description
Alexander Potashev
2017-11-11 17:19:49 UTC
Thanks for reporting this bug! I can also reproduce this behavior with Dolphin 18.04.2, so I'll mark the report as CONFIRMED. Git commit 54bd267eb96de135d2bf4cb91c6a16dffa0b012a by Elvis Angelaccio, on behalf of Ismael Asensio. Committed on 03/11/2019 at 22:00. Pushed by elvisangelaccio into branch 'master'. Get rid of search "More Options" toggle button Summary: With the new compact search filters (type/date/rating) it makes sense to show these options whenever available, and save some horizontal space on the main bar (specially for verbose languages). These options will be hidden nevertheless if the search is non-indexed or Baloo is disabled. For some nicer aesthetics D25029 should be also applied. Test Plan: Current: {F7681182} After: {F7687380} Along with D25029: {F7687385} Reviewers: elvisangelaccio, ngraham, #dolphin, #vdg Reviewed By: ngraham, #vdg Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25057 M +0 -4 src/search/dolphin_searchsettings.kcfg M +5 -54 src/search/dolphinsearchbox.cpp M +1 -4 src/search/dolphinsearchbox.h https://commits.kde.org/dolphin/54bd267eb96de135d2bf4cb91c6a16dffa0b012a Git commit 7949aee2d2528fb3adfc83d43799f1566e835466 by Ismael Asensio. Committed on 07/11/2019 at 00:51. Pushed by iasensio into branch 'master'. Make the search box more compact Summary: Reduce the spacing between widgets and remove the content margins on the extended search options to have a more compact and space-saving layout. Currently, some widgets are not even aligned. This will be even more important if we remove the toggle button for 'More Options'. Test Plan: BEFORE: {F7681182} AFTER: {F7681184} Reviewers: elvisangelaccio, ngraham, #dolphin, #vdg Reviewed By: elvisangelaccio, ngraham, #dolphin, #vdg Subscribers: kfm-devel Tags: #dolphin Differential Revision: https://phabricator.kde.org/D25028 M +1 -0 src/global.h M +1 -0 src/search/dolphinfacetswidget.cpp M +4 -0 src/search/dolphinsearchbox.cpp https://commits.kde.org/dolphin/7949aee2d2528fb3adfc83d43799f1566e835466 *** Bug 432034 has been marked as a duplicate of this bug. *** Git commit 4102ccb80457eea44ea280f0ace2a419602bc34b by Felix Ernst. Committed on 07/04/2025 at 21:09. Pushed by felixernst into branch 'master'. Rewrite search integration This huge commit is a nearly complete rewrite of the Dolphin search code. It implements most of the improved Dolphin search UI/UX as designed and discussed in a collaborative effort by Kristen McWilliam, Jin Liu, Andy Betts, Tagwerk, a few others and me. See https://invent.kde.org/system/dolphin/-/issues/46. # Notable changes - A toggle to change the search tool is provided as most contributors deemed that useful in https://invent.kde.org/system/dolphin/-/merge_requests/642#note_985112. - The default search is changed to filenamesearch for maximum reliability. - Removing all search parameters will take users back to the view state prior to starting a search instead of keeping the search results open. - The UI for choosing file types or modification dates has been made more powerful with more granularity and more options. - Most search parameters can be configured from a popup menu which gives us extra space for extra clarity. - Labels and help buttons as well as hyperlinks to settings makes sure the user always knows why some search parameters are unavailable in some contexts. - Chips show important search parameters while the popup is closed. They allow quickly removing filters. - The titles of the search and the input field placeholder message change to make clear whether file names or file contents are searched. - When the user actively switches the search tool, whether content should be searched, or whether to search everywhere, this is preserved for the initial state of the search bar when the user opens it the next time after restarting Dolphin. # Architecture - The new DolphinQuery class is independent of the UI and contains all search parameters modifiable in Dolphin as easy setters and getters. - DolphinQuery objects are also used to update the states of every component in the search UI. There is now a clear separation of UI and search configuration/DolphinQuery. - DolphinQuery is responsible for exporting to and importing from search URLs. - The search UI always reflects the currently configured DolphinQuery no matter if the user changed the UI to change the DolphinQuery or loaded a DolphinQuery/older search URL which then is reflected in the UI. - I tried to simplify all classes and their interaction between each other as much as possible. - I added some tests Related: bug 446387, bug 470136, bug 480001, bug 483578, bug 488047, bug 488845, bug 500103, bug 435119, bug 458761, bug 471556, bug 475439, bug 477969 FIXED-IN: 25.08 M +19 -4 src/CMakeLists.txt M +5 -0 src/config-dolphin.h.cmake M +22 -17 src/dolphinmainwindow.cpp M +2 -6 src/dolphinrecenttabsmenu.cpp M +103 -130 src/dolphinviewcontainer.cpp M +41 -30 src/dolphinviewcontainer.h M +2 -2 src/global.h A +356 -0 src/search/bar.cpp [License: GPL(v2.0+)] A +206 -0 src/search/bar.h [License: GPL(v2.0+)] A +150 -0 src/search/barsecondrowflowlayout.cpp [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.1)] A +48 -0 src/search/barsecondrowflowlayout.h [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.1)] A +52 -0 src/search/chip.cpp [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.1)] A +101 -0 src/search/chip.h [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.1)] A +0 -0 src/search/configurationpopup.h [License: Trivial file] M +5 -1 src/search/dolphin_searchsettings.kcfg D +0 -312 src/search/dolphinfacetswidget.cpp D +0 -84 src/search/dolphinfacetswidget.h M +339 -70 src/search/dolphinquery.cpp M +278 -37 src/search/dolphinquery.h D +0 -575 src/search/dolphinsearchbox.cpp D +0 -189 src/search/dolphinsearchbox.h A +378 -0 src/search/popup.cpp [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.1)] A +99 -0 src/search/popup.h [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.1)] A +61 -0 src/search/selectors/dateselector.cpp [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.1)] A +42 -0 src/search/selectors/dateselector.h [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.1)] A +81 -0 src/search/selectors/filetypeselector.cpp [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.1)] A +36 -0 src/search/selectors/filetypeselector.h [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.1)] A +51 -0 src/search/selectors/minimumratingselector.cpp [License: GPL(v2.0+)] A +42 -0 src/search/selectors/minimumratingselector.h [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.1)] A +189 -0 src/search/selectors/tagsselector.cpp [License: GPL(v2.0+)] A +45 -0 src/search/selectors/tagsselector.h [License: GPL(v2.0+)] A +56 -0 src/search/updatablestateinterface.h [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.1)] A +67 -0 src/search/widgetmenu.cpp [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.1)] A +63 -0 src/search/widgetmenu.h [License: LGPL(3+eV) LGPL(v3.0) LGPL(v2.1)] M +3 -3 src/tests/CMakeLists.txt M +1 -1 src/tests/dolphinmainwindowtest.cpp M +214 -64 src/tests/dolphinquerytest.cpp A +124 -0 src/tests/dolphinsearchbartest.cpp [License: GPL(v2.0+)] D +0 -63 src/tests/dolphinsearchboxtest.cpp https://invent.kde.org/system/dolphin/-/commit/4102ccb80457eea44ea280f0ace2a419602bc34b |