| Summary: | bad textarea width for rename file if filename too short | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | painless roaster <painless.roaster> |
| Component: | Application Dashboard widget | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns, hein, kde, nate, notuxius |
| Priority: | NOR | ||
| Version First Reported In: | 5.10.5 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-desktop/d6818eac6fbe495facf558b41cd570604bb7cbcb | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: |
bad textarea width
patch (for correct width) correct textarea width patch with correct rtl support |
||
Created attachment 108711 [details]
patch (for correct width)
Created attachment 108712 [details]
correct textarea width
Hi Eike, to start edit filename in plasma-desktop, you can not use 'targetItem.label.paintedWidth'. It does not work for short filenames. :-) Thanks for the patch! Can you submit it on https://phabricator.kde.org/? Patches in bugs tend to get lost. When you do, please put "BUG: 386546" on its own line in the summary section. Can confirm this bug in: Netrunner Rolling KDE Plasma 5.10.3 KDE Frameworks 5.35 KDE Applications 17.04.2 Qt5.9.0 After updating of the system -there is 'Malformed URL' bug upon creating of a new file on the desktop https://bugs.kde.org/show_bug.cgi?id=387529 so can't reproduce after update Updating based on phabricator status: - patch needs some rework to not break RTL support. You can test with plasmashell --reverse. plasma 5.122 has the same bug. Created attachment 110993 [details]
patch with correct rtl support
patch with correct rtl support
Git commit d6818eac6fbe495facf558b41cd570604bb7cbcb by Eike Hein, on behalf of Radek Bucek. Committed on 15/03/2018 at 10:28. Pushed by hein into branch 'Plasma/5.12'. bad textarea width for rename file if filename too short plasma-desktop - bad textarea width in rename file steps for replicate: create file (on plasma-destkop) with filename 't1' try rename file to: 't1 test test' Reviewers: #plasma, hein Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D10837 M +5 -7 containments/desktop/package/contents/ui/FolderView.qml https://commits.kde.org/plasma-desktop/d6818eac6fbe495facf558b41cd570604bb7cbcb |
Created attachment 108710 [details] bad textarea width steps for replicate: - create file (on plasma-destkop) with filename 't1' - try rename file to: 't1 test test' image describing a problem: bad_textarea_width.png corrupted from commit: - author: Eike Hein - date: 2017.03.01 - commit id: 6a0b3f8a3dc580046f61ae4e01c0553377c12cbf repair patch: FolderView_01.patch image describing correct width (after apply patch in attachment): correct_textarea_width.png