| Summary: | "ok/close" buttons in dialog to confirm connection deletion need to use more appropriate terms | ||
|---|---|---|---|
| Product: | [Unmaintained] plasma-nm | Reporter: | Patrick Silva <bugseforuns> |
| Component: | kcm | Assignee: | Jan Grulich <jgrulich> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-nm/e7b1b68eacc453d89c5d31a60a7627c21effeabc | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | screenshot | ||
Actually, Yes/No buttons are never recommended because they don't tend to be descriptive enough to let the user know what to do, and most users only read the buttons rather than the text. Better button names would be Remove/Keep, or something like that. Should be pretty simple, I'll see if I can put together a patch sometime soon. (In reply to Nate Graham from comment #1) > Better button names would be Remove/Keep Good idea. Thank you Nate. Turns out this dialog is a QML MessageDialog, which as far as I can tell can't take custom buttons, and there's no standard button with the label "Remove." Hmm. Ok/Cancel will have to do. Patch available: https://phabricator.kde.org/D8562 Git commit e7b1b68eacc453d89c5d31a60a7627c21effeabc by Nathaniel Graham.
Committed on 31/10/2017 at 12:51.
Pushed by ngraham into branch 'master'.
Use standard Ok/Cancel buttons for the connection removal dialog
Summary:
Change the Close button to a Cancel button in the KCM's connection removal dialog.
Test Plan:
Tested in KDE Neon. The dialog now has Ok/Cancel buttons:
{F5459178}
Reviewers: #plasma, jgrulich
Reviewed By: jgrulich
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8562
M +1 -1 kcm/qml/main.qml
https://commits.kde.org/plasma-nm/e7b1b68eacc453d89c5d31a60a7627c21effeabc
|
Created attachment 108643 [details] screenshot My summary says by itself, see the screenshot. I use opensuse krypton, plasma-nm 5.11.90git.20171029T033943~7553bbf9-15.1