Bug 386163

Summary:	Discard button should indicate that it will quit the program
Product:	[Applications] Spectacle	Reporter:	jack_sprat <home1>
Component:	General	Assignee:	Boudhayan Gupta <me>
Status:	RESOLVED NOT A BUG
Severity:	wishlist	CC:	nate
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description jack_sprat 2017-10-25 01:08:17 UTC

KDE Frameworks 5.26.0
Qt 5.9.2 (built against 5.6.1)
The xcb windowing system

'Discard' intuitively suggests that current screenshot will be dropped (as does the tooltip!) but, surprisingly, clicking it closes the window. 'Quit/Close' would be better. I note that the button title changes to 'Quit' after saving a screenshot.

'Save & exit' is handy, unless... you have a load of screenshots to take, when selecting 'Save as' from the drop-down each time becomes a chore... (although kybd shortcut is an option, I guess)

'Preferences' on 'Save...' drop-down is a bit weird - could it be a separate button below the other option checkboxes and above 'New Screenshot'?

Good work - JS

Comment 1 Nate Graham 2017-10-25 15:52:43 UTC

Thanks for the bug report! In the future, please file separate bugs for each issue; it's challenging to properly track everything in a single one. Onto your points:

- The discard button *does* discard the screenshot; it does this when it closes the window. Maybe we should change the name to "Discard and Quit"

- The Save As menu item has a keyboard shortcut, so you should use that if you have a lot of screenshots to take and don't want the window to close

- Preferences being under the Save button is tracked with https://bugs.kde.org/show_bug.cgi?id=375965

I will use this to track issue #1.

Comment 2 Nate Graham 2017-10-25 19:09:39 UTC

I've submitted a patch for that issue: https://phabricator.kde.org/D8480

Comment 3 Nate Graham 2018-01-31 04:38:16 UTC

My patch was too controversial, and I've decided to to a thorough re-work of the bottom button bar for increased usability. The new one won't even have a discard button, as it's clearly not needed--just close the window or quit the program to discard--same as every other program that lets you save files.

FWIW, the save button's last mode is now remembered by default, and as of https://phabricator.kde.org/D10198, "Save As" will be the default option.

Comment 4 Nate Graham 2018-02-05 23:38:30 UTC

Git commit 2c31ae4acba9bce24953c0f2584cd15589c4bb71 by Nathaniel Graham.
Committed on 05/02/2018 at 23:31.
Pushed by ngraham into branch 'master'.

(1/3) Remove unnecessary Discard/Quit button

Summary:
Part 1 of 3 for {T7841}
FIXED-IN: 18.04

Spectacle's main window doesn't need a discard/quit button, because there's already a user-visible way of closing the window: the titlebar's close button. The escape key does it, too. This button duplicates existing functionality and takes up room that could be used for a "Configure..." button, and has led to user confusion in the past as well (see https://bugs.kde.org/show_bug.cgi?id=386163)

Test Plan:
Tested in KDE Neon:
- Can still quit with the Escape key
- Quitting automatically discards the current screenshot if it has not been saved yet
- There's now more room in the button bar so we can add a visible "Configure..." button

{F5690995}

Reviewers: #spectacle, alexeymin

Reviewed By: #spectacle, alexeymin

Subscribers: alexeymin

Differential Revision: https://phabricator.kde.org/D10283

M  +0    -6    doc/index.docbook
M  +1    -7    src/Gui/KSMainWindow.cpp

https://commits.kde.org/spectacle/2c31ae4acba9bce24953c0f2584cd15589c4bb71