| Summary: | When there are no vaults, "Create a New Vault" button should be centered in its window | ||
|---|---|---|---|
| Product: | [Unmaintained] Plasma Vault | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Ivan Čukić <ivan.cukic> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | cryptodude |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-vault/fef23f48913f1c7027f50da83e6137bb27bab10d | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: |
Button that should be centered
Example of centered button in the Bluetooth plasmoid |
||
I disagree. Don't really see any reason for this suggestion as, for instance, the 'add' button on activities is also left aligned. I wrote more on #385987 Perhaps I should be more explicit: I think it should only be in the center when there are no vaults. That makes it clear what you have to do to get started. Once there are some vaults, it makes sense to put it in the corner, where it is right now. (that's the way the Bluetooth window is, for example) Created attachment 108487 [details]
Example of centered button in the Bluetooth plasmoid
I'm fairly neutral on this one, but was tending to agree with comment #1 ... Until your comment #4 and seeing you meant vertically centred also :) so, +1 for centred I retract my disagree in "comment 1" based on this new information, the intention of following the bluetooth screenshot sounds great to me for the single situation of not having anything there just yet. +1 to this change. I have a few things to work on first, but this is a nice improvement idea. Great! While you're at it, it might also be nice to give the button a plus icon--the standard symbol for "add something." Git commit fef23f48913f1c7027f50da83e6137bb27bab10d by Ivan Čukić. Committed on 01/12/2017 at 13:58. Pushed by ivan into branch 'master'. Better UI for the "Create a new vault" button Summary: The button to create a new vault now: - has an icon "list-add" - shows in the center of the applet when there are no existing vaults Reviewers: #plasma, cryptodude, ngraham Reviewed By: ngraham Subscribers: mart, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D9045 M +4 -0 plasma/package/contents/ui/main.qml https://commits.kde.org/plasma-vault/fef23f48913f1c7027f50da83e6137bb27bab10d |
Created attachment 108465 [details] Button that should be centered The screenshot says it all. That button should be centered, not smooshed into the corner.