| Summary: | "X" button from the red box that shows warnings/errors messages needs better contrast | ||
|---|---|---|---|
| Product: | [Plasma] Breeze | Reporter: | Patrick Silva <bugseforuns> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate, simonandric5 |
| Priority: | NOR | ||
| Version: | 5.12.4 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=357210 | ||
| Latest Commit: | https://commits.kde.org/kwidgetsaddons/00bce130d35e9dc398709e690a05f8dde70f52b3 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | screenshot | ||
Same on Arch, plasma 5.12.4. Git commit 00bce130d35e9dc398709e690a05f8dde70f52b3 by Nathaniel Graham. Committed on 08/05/2018 at 13:14. Pushed by ngraham into branch 'master'. Make KMessageWidget match Kirigami inlineMessage's style Summary: This patch makes the venerable and wonderful `KMessageWidget` match the slick style of Kirigami's new `inlineMessage` control. As a by-product, it fixes a few usability bugs. I didn't implement the drop shadow here because I couldn't get it to look right. Related: bug 381255 Test Plan: Spectacle, Breeze light, information: {F5828175} Spectacle, Breeze dark, information: {F5828176} Spectacle, Breeze light, positive: {F5828177} Spectacle, Breeze dark, positive: {F5828178} Dolphin, Breeze light, negative: {F5828180} Dolphin, Breeze dark, negative: {F5828179} Dolphin, Breeze light, warning: {F5838438} Konsole, Breeze light with dark profile theme, warning: {F5838446} Konsole, Breeze dark with light profile theme, information: {F5838445} Konsole, Breeze light, information: {F5838437} Kate, Breeze light, positive: {F5838428} Kate, Breeze dark, information: {F5838429} Reviewers: hein, #plasma, #vdg, elvisangelaccio, cfeck Reviewed By: hein, #plasma, cfeck Subscribers: broulik, anemeth, abetts, cfeck, mart, fabianr, elvisangelaccio, jnoack, #frameworks Tags: #frameworks Differential Revision: https://phabricator.kde.org/D12508 M +34 -46 src/kmessagewidget.cpp M +2 -0 src/kmessagewidget.h https://commits.kde.org/kwidgetsaddons/00bce130d35e9dc398709e690a05f8dde70f52b3 |
Created attachment 108130 [details] screenshot My summary says by itself, see the screenshot.