| Summary: | Custom shortcut ESC can ostensibly be set, but will not work | ||
|---|---|---|---|
| Product: | [Applications] gwenview | Reporter: | andydecleyre |
| Component: | general | Assignee: | Gwenview Bugs <gwenview-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ajorgederosario, andydecleyre, nate, richlv |
| Priority: | NOR | ||
| Version: | 17.04.2 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/gwenview/5bcb8cc92d3774263fe9c24cf9cbbf64da22b2f6 | Version Fixed In: | KDE Applications 18.04 |
|
Description
andydecleyre
2017-09-30 17:20:34 UTC
No change as far as 17.12.1. I am disappointed that the unrelated fix that introduced this bug was accepted, as I quit gwenview more often than I crop. Then you might be heartened to hear that a recent KDE contributor has proposed a patch to fix this: https://phabricator.kde.org/D9943 KDE is mostly sustained by volunteers, like me and the fellow who's trying to fix this issue. And in the future, perhaps you too? ;) https://community.kde.org/Get_Involved#Ways_to_contribute Thank you, that's great news. I'll be a code contributor if/when Python or Kotlin becomes a first class tool in the KDE ecosystem and/or PUCK or some other sane alternative to QML is available. I wish I could work directly on KDE and Plasma. I'd never written a line of C++ or QML in my life before I decided to dive in. They're not so bad, really. Choice of language won't hold you back with sufficient motivation! I programmed in Perl for 7 years... Git commit 5bcb8cc92d3774263fe9c24cf9cbbf64da22b2f6 by Peter Mühlenpfordt.
Committed on 22/01/2018 at 09:30.
Pushed by muhlenpfordt into branch 'master'.
Add browse mode action to action collection again
Summary:
The browse mode action with default shortcut {nav Esc} is not added to action collection (removed in D5824) and therefore not visible/changeable in {nav Settings > Configure Shortcuts}.
Using {nav Esc} as shortcut for e.g. Quit does not work.
This patch re-adds the browse mode action to action collection, but also checks for `ShortcutOverride` events to handle active tool dialogs.
Test Plan:
1. Open gwenview
2. Set alternate shortcut {nav Esc} in {nav Settings -> Configure Shortcuts} for Quit command
3. Press {nav Esc}
-> Should exit gwenview
If tool dialog (crop, red eye reduction) is active, pressing {nav Esc} should not exit gwenview, but the tool dialog first.
Reviewers: cfeck, rkflx, ngraham
Reviewed By: rkflx, ngraham
Subscribers: ngraham
Differential Revision: https://phabricator.kde.org/D9943
M +1 -0 app/mainwindow.cpp
M +19 -13 app/viewmainpage.cpp
M +3 -1 app/viewmainpage.h
https://commits.kde.org/gwenview/5bcb8cc92d3774263fe9c24cf9cbbf64da22b2f6
Is the fix slated for any particular version? Yes, see the 'Version Fixed In:' field on this page. Thank you for adding that just now! *** Bug 422606 has been marked as a duplicate of this bug. *** |